Skip to content

chore(fuzz): Print AST with numeric type suffixes#9061

Merged
aakoshh merged 14 commits intomasterfrom
af/fuzz-w-num-suffix
Jul 15, 2025
Merged

chore(fuzz): Print AST with numeric type suffixes#9061
aakoshh merged 14 commits intomasterfrom
af/fuzz-w-num-suffix

Conversation

@aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Jun 30, 2025

Description

Problem*

We disabled generating ASTs with large or negative integers because replicating failures in Noir with nargo was extremely cumbersome. Now that we have numeric suffixes though, we can print code with those and match the AST unambiguously.

Summary*

  • Change DisplayAstAsNoir to print numeric type suffixes.
  • Changes fuzz targets to enable the types that can be make unambiguous with suffixes.
  • Omit the type suffix for Field literals, since they are the default and it's a bit noisy.

Some tests seem fail with overflows now, potentially related to #9047

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 825134a Previous: 409c838 Ratio
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@aakoshh aakoshh requested review from a team and rkarabut July 10, 2025 09:40
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 8f49f9b Previous: 409c838 Ratio
rollup-block-root-empty 25.62 s 20.2 s 1.27

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@aakoshh aakoshh added this pull request to the merge queue Jul 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2025
@aakoshh aakoshh added this pull request to the merge queue Jul 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2025
@aakoshh aakoshh added this pull request to the merge queue Jul 15, 2025
Merged via the queue into master with commit 232e96b Jul 15, 2025
118 checks passed
@aakoshh aakoshh deleted the af/fuzz-w-num-suffix branch July 15, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked PR is blocked on an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants