Conversation
vezenovm
changed the title
asterite
approved these changes
Jun 18, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: be99ffa | Previous: 3838c69 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
250 s |
204 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 19, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(defunctionalize): Create a placeholder function for first-class function calls with no variants (noir-lang/noir#8697) fix(mem2reg): Keep store when any aliased reference is kept (noir-lang/noir#8960) fix(parser): let `as` have a lower precedence (noir-lang/noir#8956) fix: Match against all Value recursive types when checking for a function/closure in a global (noir-lang/noir#8967) fix(formatter): reset indetnation after group changed it (noir-lang/noir#8966) chore(validation): Ban function pointers in SSA globals (noir-lang/noir#8947) chore: address various clippy issues (noir-lang/noir#8942) chore(fuzz): Consider `RangeCheckFailed` equivalent to `ConstantDoesNotFitType` if the value matches (noir-lang/noir#8958) chore(fuzz): Use `nextest` to run nightly fuzz test (noir-lang/noir#8962) chore: minor code quality issues (noir-lang/noir#8961) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(defunctionalize): Create a placeholder function for first-class function calls with no variants (noir-lang/noir#8697) fix(mem2reg): Keep store when any aliased reference is kept (noir-lang/noir#8960) fix(parser): let `as` have a lower precedence (noir-lang/noir#8956) fix: Match against all Value recursive types when checking for a function/closure in a global (noir-lang/noir#8967) fix(formatter): reset indetnation after group changed it (noir-lang/noir#8966) chore(validation): Ban function pointers in SSA globals (noir-lang/noir#8947) chore: address various clippy issues (noir-lang/noir#8942) chore(fuzz): Consider `RangeCheckFailed` equivalent to `ConstantDoesNotFitType` if the value matches (noir-lang/noir#8958) chore(fuzz): Use `nextest` to run nightly fuzz test (noir-lang/noir#8962) chore: minor code quality issues (noir-lang/noir#8961) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Follow-up to #8905 and #8898
Summary*
Rather than using a catch-all for
contains_function_or_closurewe now recursively check all recursive Value types. Moving away from catch-all is safer and makes sure we must update this match statement if a new recursive Value is added in the future (otherwise we risk silently failing until a panic is triggered with a specific case). Moving away from catch-all more generally is also the recommendation of Veridise for these reasons.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.