Skip to content

chore: disable noncritical workflow steps which fail on external prs #8939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 2 commits into from
Jun 17, 2025
Merged

chore: disable noncritical workflow steps which fail on external prs #8939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0720c8
chore: disable noncritical workflow steps which fail on external prs
TomAFrench Jun 17, 2025
5dd3941
.
TomAFrench Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/benchmark_projects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,26 +56,26 @@ projects:
cannot_execute: true
num_runs: 5
timeout: 60
compilation-timeout: 2
compilation-memory-limit: 450
compilation-timeout: 25
compilation-memory-limit: 1500
rollup-block-root-single-tx:
repo: AztecProtocol/aztec-packages
ref: *AZ_COMMIT
path: noir-projects/noir-protocol-circuits/crates/rollup-block-root-single-tx
cannot_execute: true
num_runs: 1
timeout: 60
compilation-timeout: 180
compilation-memory-limit: 8000
compilation-timeout: 200
compilation-memory-limit: 10000
rollup-block-root:
repo: AztecProtocol/aztec-packages
ref: *AZ_COMMIT
path: noir-projects/noir-protocol-circuits/crates/rollup-block-root
num_runs: 1
timeout: 60
compilation-timeout: 150
compilation-timeout: 200
execution-timeout: 40
compilation-memory-limit: 8000
compilation-memory-limit: 10000
execution-memory-limit: 1900
rollup-merge:
repo: AztecProtocol/aztec-packages
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/reports.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,8 @@ jobs:
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)

- name: Add gates diff to sticky comment
if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
# We don't run this step on external PRs
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository
uses: marocchino/sticky-pull-request-comment@v2
with:
# delete the comment in case changes no longer impact circuit sizes
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-js-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,8 @@ jobs:
jq --slurp '. | flatten' ./reports/* | tee test_bench.json

- name: Store benchmark result
# We don't run this step on external PRs
if: github.event.pull_request.head.repo.full_name == github.repository
uses: benchmark-action/github-action-benchmark@4de1bed97a47495fc4c5404952da0499e31f5c29
with:
name: "Test Suite Duration"
Expand Down
Loading