fix: cast values before inserting them in the databus#8918
Merged
Conversation
vezenovm
reviewed
Jun 13, 2025
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 6244fe9 | Previous: 9071a7b | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
154 s |
105 s |
1.47 |
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
|
@asterite what is the status of this PR? |
Collaborator
Author
|
It's ready to review. There's this discussion but the conclusion is that it should be safe to directly cast signed integers to Field. |
5 tasks
jfecher
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #8913
Summary
Also adds a couple of validations to
make_arrayin the SSA interpreter to make sure the element count matches that of the element types, and that the element value types are the expected ones.Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.