Skip to content

fix: cast values before inserting them in the databus#8918

Merged
asterite merged 10 commits intomasterfrom
ab/cast-databus-values
Jul 11, 2025
Merged

fix: cast values before inserting them in the databus#8918
asterite merged 10 commits intomasterfrom
ab/cast-databus-values

Conversation

@asterite
Copy link
Collaborator

Description

Problem

Resolves #8913

Summary

Also adds a couple of validations to make_array in the SSA interpreter to make sure the element count matches that of the element types, and that the element value types are the expected ones.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 6244fe9 Previous: 9071a7b Ratio
test_report_zkpassport_noir-ecdsa_ 154 s 105 s 1.47
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@jfecher
Copy link
Contributor

jfecher commented Jun 26, 2025

@asterite what is the status of this PR?

@asterite
Copy link
Collaborator Author

It's ready to review. There's this discussion but the conclusion is that it should be safe to directly cast signed integers to Field.

@asterite asterite requested a review from a team July 11, 2025 16:38
@asterite asterite enabled auto-merge July 11, 2025 21:26
@asterite asterite added this pull request to the merge queue Jul 11, 2025
Merged via the queue into master with commit 1c7c6f2 Jul 11, 2025
117 of 118 checks passed
@asterite asterite deleted the ab/cast-databus-values branch July 11, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

call_data and return_data generate invalid SSA

3 participants