feat(optimization): Try to optimize ownership of assign statements#8876
Closed
feat(optimization): Try to optimize ownership of assign statements#8876
Conversation
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 46b2647 | Previous: 9580a12 | Ratio |
|---|---|---|---|
rollup-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 0b56d74 | Previous: 9580a12 | Ratio |
|---|---|---|---|
test_report_noir-lang_noir_bigcurve_ |
268 s |
223 s |
1.20 |
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
Author
|
This PR should be ready for review now, I can't seem to find any bugs with the approach here. |
jfecher
force-pushed
the
jf/assign-ownership
branch
from
4455f94 to
46b2647
Compare
vezenovm
approved these changes
Jun 11, 2025
Contributor
Author
|
Found a couple of issues with this after thinking of some more cases where the previous value should not be moved. Just checking the loop index is not sufficient since: for _ in 0 .. 10 {
foo(bar);
}
for _ in 0 .. 10 {
bar = &[];
}In the above example if we just check the loop index, it will be |
Contributor
Author
|
Abandoning this work for now to focus more on fixing bugs before 1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #8846
Summary*
With this we go from 300 array copies down to 3 (not scaling with loop iterations) for the given test program.
Note that the example program uses slices so #8867 is necessary to count the slice copies.
Additional Context
This is a draft while I verify some corner cases with the assign check.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.