Skip to content

fix: (SSA interpreter) check requires_acir_gen_predicate for enable_side_effects #8869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asterite merged 3 commits into from
Jun 10, 2025
Merged

fix: (SSA interpreter) check requires_acir_gen_predicate for enable_side_effects #8869

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c484d56
fix: (SSA interpreter) check `requires_acir_gen_predicate` for enable…
asterite Jun 10, 2025
f841292
Enable tests for ConstrainNotEqual
asterite Jun 10, 2025
8dc5f29
Current function doesn't exist in global values
asterite Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 41 additions & 18 deletions compiler/noirc_evaluator/src/ssa/interpreter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,12 @@ impl<'ssa> Interpreter<'ssa> {
try_vecmap(ids, |id| self.lookup(*id))
}

fn side_effects_enabled(&self) -> bool {
fn side_effects_enabled(&self, instruction: &Instruction) -> bool {
Comment thread
asterite marked this conversation as resolved.
match self.current_function().runtime() {
RuntimeType::Acir(_) => self.side_effects_enabled,
RuntimeType::Acir(_) => {
self.side_effects_enabled
|| !instruction.requires_acir_gen_predicate(&self.current_function().dfg)
}
RuntimeType::Brillig(_) => true,
}
}
Expand All @@ -389,9 +392,11 @@ impl<'ssa> Interpreter<'ssa> {
instruction: &Instruction,
results: &[ValueId],
) -> IResult<()> {
let side_effects_enabled = self.side_effects_enabled(instruction);

match instruction {
Instruction::Binary(binary) => {
let result = self.interpret_binary(binary)?;
let result = self.interpret_binary(binary, side_effects_enabled)?;
self.define(results[0], result);
Ok(())
}
Expand All @@ -410,7 +415,7 @@ impl<'ssa> Interpreter<'ssa> {
Instruction::Constrain(lhs_id, rhs_id, constrain_error) => {
let lhs = self.lookup(*lhs_id)?;
let rhs = self.lookup(*rhs_id)?;
if self.side_effects_enabled() && lhs != rhs {
if side_effects_enabled && lhs != rhs {
let lhs = lhs.to_string();
let rhs = rhs.to_string();
let lhs_id = *lhs_id;
Expand All @@ -433,7 +438,7 @@ impl<'ssa> Interpreter<'ssa> {
Instruction::ConstrainNotEqual(lhs_id, rhs_id, constrain_error) => {
let lhs = self.lookup(*lhs_id)?;
let rhs = self.lookup(*rhs_id)?;
if self.side_effects_enabled() && lhs == rhs {
if side_effects_enabled && lhs == rhs {
let lhs = lhs.to_string();
let rhs = rhs.to_string();
let lhs_id = *lhs_id;
Expand All @@ -453,10 +458,16 @@ impl<'ssa> Interpreter<'ssa> {
}
Ok(())
}
Instruction::RangeCheck { value, max_bit_size, assert_message } => {
self.interpret_range_check(*value, *max_bit_size, assert_message.as_ref())
Instruction::RangeCheck { value, max_bit_size, assert_message } => self
.interpret_range_check(
*value,
*max_bit_size,
assert_message.as_ref(),
side_effects_enabled,
),
Instruction::Call { func, arguments } => {
self.interpret_call(*func, arguments, results, side_effects_enabled)
}
Instruction::Call { func, arguments } => self.interpret_call(*func, arguments, results),
Instruction::Allocate => {
self.interpret_allocate(results[0]);
Ok(())
Expand All @@ -468,11 +479,18 @@ impl<'ssa> Interpreter<'ssa> {
Ok(())
}
Instruction::ArrayGet { array, index, offset } => {
self.interpret_array_get(*array, *index, *offset, results[0])
}
Instruction::ArraySet { array, index, value, mutable, offset } => {
self.interpret_array_set(*array, *index, *value, *mutable, *offset, results[0])
self.interpret_array_get(*array, *index, *offset, results[0], side_effects_enabled)
}
Instruction::ArraySet { array, index, value, mutable, offset } => self
.interpret_array_set(
*array,
*index,
*value,
*mutable,
*offset,
results[0],
side_effects_enabled,
),
Instruction::IncrementRc { value } => self.interpret_inc_rc(*value),
Instruction::DecrementRc { value } => self.interpret_dec_rc(*value),
Instruction::IfElse { then_condition, then_value, else_condition, else_value } => self
Expand Down Expand Up @@ -556,8 +574,9 @@ impl<'ssa> Interpreter<'ssa> {
value_id: ValueId,
max_bit_size: u32,
error_message: Option<&String>,
side_effects_enabled: bool,
) -> IResult<()> {
if !self.side_effects_enabled() {
if !side_effects_enabled {
return Ok(());
}

Expand Down Expand Up @@ -628,11 +647,12 @@ impl<'ssa> Interpreter<'ssa> {
function_id: ValueId,
argument_ids: &[ValueId],
results: &[ValueId],
side_effects_enabled: bool,
) -> IResult<()> {
let function = self.lookup(function_id)?;
let mut arguments = try_vecmap(argument_ids, |argument| self.lookup(*argument))?;

let new_results = if self.side_effects_enabled() {
let new_results = if side_effects_enabled {
match function {
Value::Function(id) => {
// If we're crossing a constrained -> unconstrained boundary we have to wipe
Expand Down Expand Up @@ -762,8 +782,9 @@ impl<'ssa> Interpreter<'ssa> {
index: ValueId,
offset: ArrayOffset,
result: ValueId,
side_effects_enabled: bool,
) -> IResult<()> {
let element = if self.side_effects_enabled() {
let element = if side_effects_enabled {
let array = self.lookup_array_or_slice(array, "array get")?;
let index = self.lookup_u32(index, "array get index")?;
let index = index - offset.to_u32();
Expand All @@ -776,6 +797,7 @@ impl<'ssa> Interpreter<'ssa> {
Ok(())
}

#[allow(clippy::too_many_arguments)]
fn interpret_array_set(
&mut self,
array: ValueId,
Expand All @@ -784,10 +806,11 @@ impl<'ssa> Interpreter<'ssa> {
mutable: bool,
offset: ArrayOffset,
result: ValueId,
side_effects_enabled: bool,
) -> IResult<()> {
let array = self.lookup_array_or_slice(array, "array set")?;

let result_array = if self.side_effects_enabled() {
let result_array = if side_effects_enabled {
let index = self.lookup_u32(index, "array set index")?;
let index = index - offset.to_u32();
let value = self.lookup(value)?;
Expand Down Expand Up @@ -1047,7 +1070,7 @@ macro_rules! apply_int_comparison_op {
}

impl Interpreter<'_> {
fn interpret_binary(&mut self, binary: &Binary) -> IResult<Value> {
fn interpret_binary(&mut self, binary: &Binary, side_effects_enabled: bool) -> IResult<Value> {
let lhs_id = binary.lhs;
let rhs_id = binary.rhs;
let lhs = self.lookup_numeric(lhs_id, "binary op lhs")?;
Expand All @@ -1066,7 +1089,7 @@ impl Interpreter<'_> {
}

// Disable this instruction if it is side-effectful and side effects are disabled.
if !self.side_effects_enabled() && binary.requires_acir_gen_predicate(self.dfg()) {
if !side_effects_enabled {
Comment thread
jfecher marked this conversation as resolved.
let zero = NumericValue::zero(lhs.get_type());
return Ok(Value::Numeric(zero));
}
Expand Down
87 changes: 53 additions & 34 deletions compiler/noirc_evaluator/src/ssa/interpreter/tests/instructions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ use noirc_frontend::Shared;
use crate::ssa::{
interpreter::{
InterpreterError, NumericValue, Value,
tests::{expect_value, expect_values, expect_values_with_args, from_constant},
tests::{
expect_value, expect_value_with_args, expect_values, expect_values_with_args,
from_constant,
},
value::ReferenceValue,
},
ir::{
Expand Down Expand Up @@ -627,8 +630,8 @@ fn constrain() {
}

#[test]
fn constrain_disabled_by_enable_side_effects() {
executes_with_no_errors(
fn constrain_not_disabled_by_enable_side_effects() {
expect_error(
"
acir(inline) fn main f0 {
b0():
Expand All @@ -640,34 +643,33 @@ fn constrain_disabled_by_enable_side_effects() {
);
}

// SSA Parser does not yet parse ConstrainNotEqual
// #[test]
// fn constrain_not_equal() {
// executes_with_no_errors(
// "
// acir(inline) fn main f0 {
// b0():
// v0 = eq u8 3, u8 4
// constrain v0 != u1 1
// return
// }
// ",
// );
// }
//
// #[test]
// fn constrain_not_equal_disabled_by_enable_side_effects() {
// executes_with_no_errors(
// "
// acir(inline) fn main f0 {
// b0():
// enable_side_effects u1 0
// constrain u1 1 != u1 1
// return
// }
// ",
// );
// }
#[test]
fn constrain_not_equal() {
executes_with_no_errors(
"
acir(inline) fn main f0 {
b0():
v0 = eq u8 3, u8 4
constrain v0 != u1 1
return
}
",
);
}

#[test]
fn constrain_not_equal_not_disabled_by_enable_side_effects() {
expect_error(
"
acir(inline) fn main f0 {
b0():
enable_side_effects u1 0
constrain u1 1 != u1 1
return
}
",
);
}

#[test]
fn range_check() {
Expand Down Expand Up @@ -697,8 +699,8 @@ fn range_check_fail() {
}

#[test]
fn range_check_disabled_by_enable_side_effects() {
executes_with_no_errors(
fn range_check_not_disabled_by_enable_side_effects() {
expect_error(
"
acir(inline) fn main f0 {
b0():
Expand Down Expand Up @@ -846,7 +848,7 @@ fn array_get_with_offset() {
}

#[test]
fn array_get_disabled_by_enable_side_effects() {
fn array_get_not_disabled_by_enable_side_effects_if_index_is_known_to_be_safe() {
let value = expect_value(
r#"
acir(inline) fn main f0 {
Expand All @@ -858,6 +860,23 @@ fn array_get_disabled_by_enable_side_effects() {
}
"#,
);
assert_eq!(value, from_constant(2_u32.into(), NumericType::NativeField));
}

#[test]
fn array_get_disabled_by_enable_side_effects_if_index_is_not_known_to_be_safe() {
let value = expect_value_with_args(
r#"
acir(inline) fn main f0 {
b0(v2: u32):
enable_side_effects u1 0
v0 = make_array [Field 1, Field 2] : [Field; 2]
v1 = array_get v0, index v2 -> Field
return v1
}
"#,
vec![Value::Numeric(NumericValue::U32(1))],
);
assert_eq!(value, from_constant(0_u32.into(), NumericType::NativeField));
}

Expand Down