Skip to content

chore: Incorrect clippy warning blocking PRs #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 2 commits into from
Jun 12, 2025
Merged

chore: Incorrect clippy warning blocking PRs #8861

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df422bb
Clippy
jfecher Jun 10, 2025
568dc40
Merge branch 'master' into jf/clip
jfecher Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tooling/nargo_cli/src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ fn read_workspace(
}

/// "with_workspace", but use a dummy workspace when 'debug_compile_stdin' is enabled
#[allow(clippy::field_reassign_with_default)]
fn compile_with_maybe_dummy_workspace(
cmd: compile_cmd::CompileCommand,
config: NargoConfig,
Expand All @@ -198,6 +199,8 @@ fn compile_with_maybe_dummy_workspace(

// dummy root dir
let root_dir = PathBuf::new();
// This `PackageMetadata::default()` is leading to a clippy error but the suggested solution
// is invalid because the fields are private
let mut package = PackageMetadata::default();
package.name = Some(package_name.clone());
package.package_type = Some("bin".into());
Expand Down
Loading