fix(ssa): Experiment with removing the last stores optimization in mem2reg#8745
Closed
fix(ssa): Experiment with removing the last stores optimization in mem2reg#8745
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ACVM Benchmarks
Details
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
258432 ns/iter (± 770) |
255254 ns/iter (± 985) |
1.01 |
perfectly_parallel_opcodes |
226706 ns/iter (± 2197) |
224321 ns/iter (± 1041) |
1.01 |
perfectly_parallel_batch_inversion_opcodes |
3586898 ns/iter (± 14270) |
3211138 ns/iter (± 3949) |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
vezenovm
changed the title
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
There was a problem hiding this comment.
Execution Time
Details
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
private-kernel-inner |
0.029 s |
0.028 s |
1.04 |
private-kernel-reset |
0.167 s |
0.165 s |
1.01 |
private-kernel-tail |
0.011 s |
0.011 s |
1 |
rollup-base-private |
0.311 s |
0.31 s |
1.00 |
rollup-base-public |
0.199 s |
0.204 s |
0.98 |
rollup-block-root |
11.3 s |
12.1 s |
0.93 |
rollup-merge |
0.004 s |
0.004 s |
1 |
rollup-root |
0.01 s |
0.009 s |
1.11 |
semaphore-depth-10 |
0.021 s |
0.021 s |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Time
Details
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
private-kernel-inner |
2.466 s |
2.334 s |
1.06 |
private-kernel-reset |
8.63 s |
7.078 s |
1.22 |
private-kernel-tail |
1.08 s |
1.052 s |
1.03 |
rollup-base-private |
18.1 s |
16.02 s |
1.13 |
rollup-base-public |
14.48 s |
14.08 s |
1.03 |
rollup-block-root-empty |
1.286 s |
1.274 s |
1.01 |
rollup-block-root-single-tx |
126 s |
122 s |
1.03 |
rollup-block-root |
130 s |
126 s |
1.03 |
rollup-merge |
1.122 s |
1.062 s |
1.06 |
rollup-root |
1.712 s |
1.594 s |
1.07 |
semaphore-depth-10 |
0.84 s |
0.836 s |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
private-kernel-reset |
8.63 s |
7.078 s |
1.22 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
Artifact Size
Details
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
private-kernel-inner |
1134.8 KB |
1133.3 KB |
1.00 |
private-kernel-reset |
2158 KB |
2156.7 KB |
1.00 |
private-kernel-tail |
591.7 KB |
589 KB |
1.00 |
rollup-base-private |
5129.8 KB |
5129.7 KB |
1.00 |
rollup-base-public |
4070.5 KB |
4071.2 KB |
1.00 |
rollup-block-root-empty |
257.1 KB |
257 KB |
1.00 |
rollup-block-root-single-tx |
25709.7 KB |
25708.1 KB |
1.00 |
rollup-block-root |
25723.6 KB |
25715.1 KB |
1.00 |
rollup-merge |
183.7 KB |
183.7 KB |
1 |
rollup-root |
419.4 KB |
418.6 KB |
1.00 |
semaphore-depth-10 |
636.4 KB |
636.3 KB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Test Suite Duration
Details
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
65 s |
63 s |
1.03 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
98 s |
94 s |
1.04 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
47 s |
42 s |
1.12 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
239 s |
199 s |
1.20 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib |
204 s |
192 s |
1.06 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
69 s |
70 s |
0.99 |
test_report_noir-lang_noir_bigcurve_ |
246 s |
232 s |
1.06 |
test_report_noir-lang_sha512_ |
38 s |
31 s |
1.23 |
test_report_zkpassport_noir_rsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
239 s |
199 s |
1.20 |
test_report_noir-lang_sha512_ |
38 s |
31 s |
1.23 |
test_report_zkpassport_noir_rsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
private-kernel-inner |
293.35 MB |
292.48 MB |
1.00 |
private-kernel-reset |
586.14 MB |
533.03 MB |
1.10 |
private-kernel-tail |
192.35 MB |
192.31 MB |
1.00 |
rollup-base-private |
1470 MB |
1390 MB |
1.06 |
rollup-base-public |
1560 MB |
1550 MB |
1.01 |
rollup-block-root-empty |
354.91 MB |
353.41 MB |
1.00 |
rollup-block-root-single-tx |
7840 MB |
7160 MB |
1.09 |
rollup-block-root |
7850 MB |
7170 MB |
1.09 |
rollup-merge |
337.67 MB |
337.62 MB |
1.00 |
rollup-root |
392.26 MB |
391.89 MB |
1.00 |
semaphore_depth_10 |
106.4 MB |
106.4 MB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: fb89406 | Previous: cb4951d | Ratio |
|---|---|---|---|
private-kernel-inner |
201.52 MB |
201.52 MB |
1 |
private-kernel-reset |
225.37 MB |
225.36 MB |
1.00 |
private-kernel-tail |
176.68 MB |
176.66 MB |
1.00 |
rollup-base-private |
501.76 MB |
501.76 MB |
1 |
rollup-base-public |
498.08 MB |
498.08 MB |
1 |
rollup-block-root |
1410 MB |
1410 MB |
1 |
rollup-merge |
322.46 MB |
322.46 MB |
1 |
rollup-root |
328.17 MB |
328.15 MB |
1.00 |
semaphore_depth_10 |
70.97 MB |
70.97 MB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
Author
|
There are several regressions but largest bump looks to be contained to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
As as an alternative to #8743 I just want to see the effects of removing this optimization where we remove the remaining last stores.
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.