Skip to content

chore: ensure blake3 input length is less than 1024 bytes#8689

Closed
kashbrti wants to merge 1 commit intomasterfrom
kb/blake3_len
Closed

chore: ensure blake3 input length is less than 1024 bytes#8689
kashbrti wants to merge 1 commit intomasterfrom
kb/blake3_len

Conversation

@kashbrti
Copy link
Contributor

Description

BB does not behave correctly when the blake3 input length is longer than 1024 bytes.
This leads to programs that we can't generate the BB circuits for correctly.
However, due to quirks in BB, this will only show up as a proof not being able to be verified.
So I think it'd be a good idea to catch this in stdlib

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made #8690 which addresses this inside of the stdlib rather than the ACVM.

@kashbrti
Copy link
Contributor Author

ok great. Gave your PR a quick review. should we close this then?

@TomAFrench TomAFrench closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants