chore: ensure blake3 input length is less than 1024 bytes#8689
Closed
chore: ensure blake3 input length is less than 1024 bytes#8689
blake3 input length is less than 1024 bytes#8689Conversation
5 tasks
TomAFrench
requested changes
May 27, 2025
Member
TomAFrench
left a comment
There was a problem hiding this comment.
I've made #8690 which addresses this inside of the stdlib rather than the ACVM.
Contributor
Author
|
ok great. Gave your PR a quick review. should we close this then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BB does not behave correctly when the
blake3input length is longer than 1024 bytes.This leads to programs that we can't generate the BB circuits for correctly.
However, due to quirks in BB, this will only show up as a proof not being able to be verified.
So I think it'd be a good idea to catch this in
stdlibProblem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.