Skip to content

fix: restore the all_or_nothing witness/constant for ec-add#8624

Merged
TomAFrench merged 2 commits intomasterfrom
gd/revert_ec_add_to_all_or_nothing
May 22, 2025
Merged

fix: restore the all_or_nothing witness/constant for ec-add#8624
TomAFrench merged 2 commits intomasterfrom
gd/revert_ec_add_to_all_or_nothing

Conversation

@guipublic
Copy link
Contributor

Description

Problem*

Ec addition does not allow constant and non-constant mix for their inputs.

Summary*

Revert the changes from #8552 which mix constant and non constant inputs for ec-add

Additional Context

This is due to this issue: AztecProtocol/barretenberg#1108
We should investigate if this impact also the ec-add-unsafe and see if there is a workaround if this is the case..

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

Changes to circuit sizes

Generated at commit: 4e2b7cdf4015b59980e6b546c4ff73299d37673d, compared to commit: b2bfdb7bb0fc661bfb27da365f108cf131771295

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
regression_7744 +1 ❌ +14.29% +16 ❌ +38.10%
regression_5045 +1 ❌ +10.00% +16 ❌ +1.33%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
regression_7744 8 (+1) +14.29% 58 (+16) +38.10%
regression_5045 11 (+1) +10.00% 1,215 (+16) +1.33%
embedded_curve_ops 14 (+1) +7.69% 5,971 (+16) +0.27%

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 96c7388 Previous: b2bfdb7 Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob 3 s 2 s 1.50
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench TomAFrench enabled auto-merge May 22, 2025 11:22
@TomAFrench TomAFrench added this pull request to the merge queue May 22, 2025
Merged via the queue into master with commit aea7a38 May 22, 2025
98 checks passed
@TomAFrench TomAFrench deleted the gd/revert_ec_add_to_all_or_nothing branch May 22, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants