Skip to content

chore(ci): Update expected failures for noir_rsa #8608

Merged
TomAFrench merged 2 commits intomasterfrom
mv/expected-rsa-type-failures
May 21, 2025
Merged

chore(ci): Update expected failures for noir_rsa #8608
TomAFrench merged 2 commits intomasterfrom
mv/expected-rsa-type-failures

Conversation

@vezenovm
Copy link
Contributor

@vezenovm vezenovm commented May 21, 2025

Description

Problem*

Resolves https://github.com/noir-lang/noir/actions/runs/15170666556/job/42659960929 and I am sure jobs on other PRs

Summary*

Several tests in noir_rsa have begun to fail with Type annotations needed. As per #7843 (comment) it looks even though the compilation failures were resolved we still have failures in the tests.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested a review from TomAFrench May 21, 2025 19:33
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: a9d969e Previous: 4d7c8f7 Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob 3 s 2 s 1.50
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@vezenovm vezenovm requested a review from asterite May 21, 2025 19:46
@TomAFrench TomAFrench enabled auto-merge May 21, 2025 19:48
@TomAFrench TomAFrench added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit 0031c31 May 21, 2025
98 checks passed
@TomAFrench TomAFrench deleted the mv/expected-rsa-type-failures branch May 21, 2025 20:12
@asterite
Copy link
Collaborator

Yes, sorry! I initially marked these repos as "they don't compile" but then I realized they do compile, they just have errors. I pushed a commit to revert the wrong commit first, then I was about to push the changes in this PR but it got into the queue first (I didn't realize it was queued). Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants