chore(ci): Update expected failures for noir_rsa #8608
Merged
TomAFrench merged 2 commits intomasterfrom May 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: a9d969e | Previous: 4d7c8f7 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
3 s |
2 s |
1.50 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
TomAFrench
approved these changes
May 21, 2025
Collaborator
|
Yes, sorry! I initially marked these repos as "they don't compile" but then I realized they do compile, they just have errors. I pushed a commit to revert the wrong commit first, then I was about to push the changes in this PR but it got into the queue first (I didn't realize it was queued). Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves https://github.com/noir-lang/noir/actions/runs/15170666556/job/42659960929 and I am sure jobs on other PRs
Summary*
Several tests in noir_rsa have begun to fail with
Type annotations needed. As per #7843 (comment) it looks even though the compilation failures were resolved we still have failures in the tests.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.