Skip to content

chore(test): Add more tests for defunctionalization#8481

Merged
TomAFrench merged 2 commits intomasterfrom
af/test-defunctionalize
May 13, 2025
Merged

chore(test): Add more tests for defunctionalization#8481
TomAFrench merged 2 commits intomasterfrom
af/test-defunctionalize

Conversation

@aakoshh
Copy link
Contributor

@aakoshh aakoshh commented May 13, 2025

Description

Problem*

Part of #8218

Summary*

Add more unit tests to defunctionalization:

  • Test that functions stored in references are defunctionalized
  • Add a post-check to show that after defunctionalization no blocks take function parameters

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@aakoshh aakoshh marked this pull request as ready for review May 13, 2025 13:21
@aakoshh aakoshh requested a review from a team May 13, 2025 13:22
@aakoshh aakoshh changed the title chore: Test that functions stored are defunctionalized chore: Add more tests for defunctionalization May 13, 2025
@aakoshh aakoshh changed the title chore: Add more tests for defunctionalization chore(test): Add more tests for defunctionalization May 13, 2025
@aakoshh aakoshh requested a review from michaeljklein May 13, 2025 13:23
@TomAFrench TomAFrench added this pull request to the merge queue May 13, 2025
Merged via the queue into master with commit 7587555 May 13, 2025
128 checks passed
@TomAFrench TomAFrench deleted the af/test-defunctionalize branch May 13, 2025 14:56
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request May 14, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: pass Field to ToBits intrinsic in remove_bit_shifts optimization
(noir-lang/noir#8493)
fix: don't produce `index Field` in value merger
(noir-lang/noir#8492)
fix: allowing accessing associated constants via `Self::...`
(noir-lang/noir#8403)
fix: remove unused generic in static_assert
(noir-lang/noir#8488)
fix: disallow generics on entry points
(noir-lang/noir#8490)
chore(test): Replicate comptime stack overflow in a test
(noir-lang/noir#8473)
feat: `#[test(only_fail_with = "...")]`
(noir-lang/noir#8460)
fix: variable used in fmtstr inside lambda wasn't tracked as captured
(noir-lang/noir#8487)
chore(test): Add more tests for defunctionalization
(noir-lang/noir#8481)
END_COMMIT_OVERRIDE

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants