Skip to content

chore(fuzz): Break up the AST fuzzer compare module #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aakoshh merged 4 commits into from
May 9, 2025
Merged

chore(fuzz): Break up the AST fuzzer compare module #8431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70cbfb0
Rename CompareSsa to CompareCompiled
aakoshh May 9, 2025
f280d04
Rename ComparePasses to ComparePipelines
aakoshh May 9, 2025
2338495
Break up the compare module
aakoshh May 9, 2025
7755f43
Remove println
aakoshh May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tooling/ast_fuzzer/fuzz/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use acir::circuit::ExpressionWidth;
use color_eyre::eyre;
use noir_ast_fuzzer::DisplayAstAsNoir;
use noir_ast_fuzzer::compare::{CompareComptime, CompareResult, CompareSsa, HasPrograms};
use noir_ast_fuzzer::compare::{CompareCompiled, CompareComptime, CompareResult, HasPrograms};
use noirc_abi::input_parser::Format;
use noirc_evaluator::brillig::Brillig;
use noirc_evaluator::ssa::{SsaPass, primary_passes, secondary_passes};
Expand Down Expand Up @@ -79,9 +79,9 @@ where
}

/// Compare the execution result and print the inputs if the result is a failure.
pub fn compare_results<P>(inputs: &CompareSsa<P>, result: &CompareResult) -> eyre::Result<()>
pub fn compare_results<P>(inputs: &CompareCompiled<P>, result: &CompareResult) -> eyre::Result<()>
where
CompareSsa<P>: HasPrograms,
CompareCompiled<P>: HasPrograms,
{
let res = result.return_value_or_err();

Expand Down
4 changes: 2 additions & 2 deletions tooling/ast_fuzzer/fuzz/src/targets/acir_vs_brillig.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use arbitrary::Arbitrary;
use arbitrary::Unstructured;
use color_eyre::eyre;
use noir_ast_fuzzer::Config;
use noir_ast_fuzzer::compare::{CompareOptions, ComparePasses};
use noir_ast_fuzzer::compare::{CompareOptions, ComparePipelines};
use noir_ast_fuzzer::rewrite::change_all_functions_into_unconstrained;

pub fn fuzz(u: &mut Unstructured) -> eyre::Result<()> {
Expand All @@ -19,7 +19,7 @@ pub fn fuzz(u: &mut Unstructured) -> eyre::Result<()> {
..Default::default()
};

let inputs = ComparePasses::arb(
let inputs = ComparePipelines::arb(
u,
config,
|u, program| {
Expand Down
4 changes: 2 additions & 2 deletions tooling/ast_fuzzer/fuzz/src/targets/min_vs_full.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::{
};
use arbitrary::{Arbitrary, Unstructured};
use color_eyre::eyre;
use noir_ast_fuzzer::compare::{CompareOptions, ComparePasses};
use noir_ast_fuzzer::compare::{CompareOptions, ComparePipelines};
use noir_ast_fuzzer::{
Config, compare::CompareResult, rewrite::change_all_functions_into_unconstrained,
};
Expand All @@ -23,7 +23,7 @@ pub fn fuzz(u: &mut Unstructured) -> eyre::Result<()> {
..Default::default()
};

let inputs = ComparePasses::arb(
let inputs = ComparePipelines::arb(
u,
config,
|_u, program| {
Expand Down
Loading
Loading