fix: Use regex for test function name parsing in debugger build script#8381
Closed
GarmashAlex wants to merge 1 commit intonoir-lang:masterfrom
Closed
fix: Use regex for test function name parsing in debugger build script#8381GarmashAlex wants to merge 1 commit intonoir-lang:masterfrom
GarmashAlex wants to merge 1 commit intonoir-lang:masterfrom
Conversation
Contributor
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
Member
|
Is this completely AI generated? |
Contributor
Author
Most of this :( Sorry... I was trying to find a useful way to contribute. |
Member
|
We have a policy of not accepting PRs which consist entirely of LLM output due to the fact that it ends up functionally being a DOS on maintainers because we then need to do all the checking which would otherwise be done by the author (as shown by this PR keeping the old method as a fallback). I'm sorry but I'm going to close this PR. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the multiple .split() and .unwrap() calls used for parsing test function names in the debugger build script with a regex-based approach. The new implementation:
This makes the test function name parsing more robust and maintainable, while avoiding potential panic situations when parsing complex function signatures.
Problem*
Fix issue #8352
Additional Context
The previous implementation was using a series of string splits and unwraps which could fail when dealing with more complex function signatures. The regex approach provides a cleaner and more reliable solution.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.