fix(ssa): Do not remove unused checked binary ops#8303
Merged
TomAFrench merged 3 commits intomasterfrom May 1, 2025
Merged
Conversation
Contributor
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
TomAFrench
approved these changes
May 1, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 2, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: disallow emitting multiple `MemoryInit` opcodes for the same block (noir-lang/noir#8291) fix(ssa): Remove unused calls to pure functions (noir-lang/noir#8298) fix(ssa): Do not remove unused checked binary ops (noir-lang/noir#8303) fix: Return zero and insert an assertion if RHS bit size is over the limit in euclidian division (noir-lang/noir#8294) feat: remove unnecessary dynamic arrays when pushing onto slices (noir-lang/noir#8287) feat(testing): Add SSA interpreter for testing SSA (noir-lang/noir#8115) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #8302
Resolves #8230
Resolves #8231
Resolves #8233
Summary*
We are removing all binary ops. As binary ops are side effectual based upon a predicate we should not be removing them.
Additional Context
In follow-ups we can check whether the predicate will always be false. But for now this is sufficient to get ACIR and Brillig aligned.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.