Skip to content

feat: disallow emitting multiple MemoryInit opcodes for the same block #8291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
May 1, 2025
Merged

feat: disallow emitting multiple MemoryInit opcodes for the same block #8291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions acvm-repo/acvm/src/compiler/simulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ impl CircuitSimulator {
return false;
}
}
self.initialized_blocks.insert(*block_id);
true
self.initialized_blocks.insert(*block_id)
}
Opcode::BrilligCall { id: _, inputs, outputs, predicate } => {
for input in inputs {
Expand Down Expand Up @@ -316,4 +315,26 @@ mod tests {

assert!(!CircuitSimulator::default().check_circuit(&circuit));
}

#[test]
fn reports_false_when_attempting_to_reinitialize_memory_block() {
let circuit = test_circuit(
vec![
Opcode::MemoryInit {
block_id: BlockId(0),
init: vec![Witness(0)],
block_type: BlockType::Memory,
},
Opcode::MemoryInit {
block_id: BlockId(0),
init: vec![Witness(0)],
block_type: BlockType::Memory,
},
],
BTreeSet::from([Witness(0)]),
PublicInputs::default(),
);

assert!(!CircuitSimulator::default().check_circuit(&circuit));
}
}
Loading