fix(docs): bar -> foo correction#8289
Closed
ciaranightingale wants to merge 1 commit intonoir-lang:masterfrom
Closed
fix(docs): bar -> foo correction#8289ciaranightingale wants to merge 1 commit intonoir-lang:masterfrom
ciaranightingale wants to merge 1 commit intonoir-lang:masterfrom
Conversation
I noticed that the docs referenced `bar::from_foo()` when this function is from the parent module `foo.nr` Let me know if I am misunderstanding!
Contributor
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the docs referenced
bar::from_foo()when this function is from the parent modulefoo.nrLet me know if I am misunderstanding!
Problem*
Comments reference function from child module rather than parent module.
Documentation*
https://noir-lang.org/docs/noir/modules_packages_crates/modules#referencing-a-parent-module
Check one: