Conversation
aakoshh
reviewed
Apr 22, 2025
aakoshh
approved these changes
Apr 22, 2025
Contributor
aakoshh
left a comment
There was a problem hiding this comment.
Great, the detailed proof/explanation is super helpful 👏
TomAFrench
requested changes
Apr 22, 2025
Member
TomAFrench
left a comment
There was a problem hiding this comment.
We should be blocking the i1 type.
Contributor
Author
Wasn't sure if we just wanted to block i1. Even after blocking i1 in the frontend, would we still not want this logic as to prevent any differences between ACIR and Brillig? |
Member
|
I can have a think about this tomorrow but I'm pretty sure that SSA can create arbitrary bitsize types which gives opportunities for all kinds of funky behaviour. We could also just disallow creating |
Contributor
Author
This would be simplest. Otherwise I do think we probably need to handle i1 as done here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #7973
Summary*
From comments in the PR:
i1 division:
i1 modulo:
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.