chore(ssa): Do not run Brillig entry point analysis when no globals have been declared#8152
chore(ssa): Do not run Brillig entry point analysis when no globals have been declared#8152
Conversation
|
We've got a panic in |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 86cad8b | Previous: 7d8b3bc | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
49 s |
40 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
…globals' into mv/skip-entry-point-dup-when-no-globals
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: be1bf92 | Previous: 1df587d | Ratio |
|---|---|---|---|
private-kernel-inner |
270.8 MB |
209.58 MB |
1.29 |
private-kernel-reset |
454.35 MB |
246.67 MB |
1.84 |
rollup-block-root |
7780 MB |
1710 MB |
4.55 |
rollup-root |
322.46 MB |
261.28 MB |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Yeah, we then need to handle that we did not specialize entry points during Brillig globals code gen. We also hoist constants during the globals code gen so that complicates things a bit further as well. This is looking to be a bit more trouble than it is worth at the moment, so I am going to close. |
Description
Problem*
No issue just something I noticed while looking at #8099.
We already skip Brillig entry point specialization if we have a single Brillig entry point (e.g.
mainis Brillig). We can also avoid specializing Brillig functions for programs that do not use globals at all.Summary*
Check whether any globals have been declared. If not we can skip the Brillig entry point analysis.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.