Skip to content

chore: add another test for try_merge_only_changed_indices #8143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asterite wants to merge 2 commits into from
Closed

chore: add another test for try_merge_only_changed_indices #8143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9adbff7
chore: add another test for try_merge_only_changed_indices
asterite Apr 21, 2025
431dd16
Update to match the actual program that fails
asterite Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 206 additions & 0 deletions compiler/noirc_evaluator/src/ssa/opt/remove_if_else.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,4 +382,210 @@ mod tests {
}
"#);
}

#[test]
fn try_merge_only_changed_indices_2() {
let src = "
g0 = u32 2

acir(inline) predicate_pure fn main f0 {
b0(v1: [Field; 2], v2: [Field; 2]):
v4 = array_get v1, index u32 0 -> Field
v6 = array_get v1, index u32 1 -> Field
v7 = array_get v2, index u32 0 -> Field
v8 = array_get v2, index u32 1 -> Field
v9 = make_array [v4, v6, v7, v8] : [Field; 4]
v11 = make_array [Field 0, Field 0, Field 0, Field 0] : [Field; 4]
v12 = make_array [Field 0, Field 0, Field 0, Field 0] : [Field; 4]
v13 = allocate -> &mut [Field; 4]
v14 = allocate -> &mut u32
v15 = allocate -> &mut [Field; 4]
v16 = allocate -> &mut u32
v17 = array_get v1, index u32 0 -> Field
v18 = eq v17, Field 0
v19 = not v18
enable_side_effects v19
v20 = array_get v1, index u32 0 -> Field
v21 = make_array [v20, Field 0, Field 0, Field 0] : [Field; 4]
v22 = if v19 then v21 else (if v18) v11
v23 = cast v19 as u32
v24 = cast v18 as u32
enable_side_effects u1 1
v26 = array_get v1, index u32 1 -> Field
v27 = eq v26, Field 0
v28 = not v27
enable_side_effects v28
v29 = array_get v1, index u32 1 -> Field
v31 = lt v23, u32 4
v32 = mul v31, v28
constrain v32 == v28
v33 = lt v23, u32 4
v34 = mul v33, v28
constrain v34 == v28
v35 = array_set v22, index v23, value v29
v36 = add v23, u32 1
v37 = if v28 then v35 else (if v27) v22
v38 = cast v28 as u32
v39 = cast v27 as u32
v40 = unchecked_mul v38, v36
v41 = unchecked_mul v39, v23
v42 = unchecked_add v40, v41
enable_side_effects u1 1
v43 = array_get v2, index u32 0 -> Field
v44 = eq v43, Field 0
v45 = not v44
enable_side_effects v45
v46 = array_get v2, index u32 0 -> Field
v47 = make_array [v46, Field 0, Field 0, Field 0] : [Field; 4]
v48 = if v45 then v47 else (if v44) v12
v49 = cast v45 as u32
v50 = cast v44 as u32
enable_side_effects u1 1
v51 = array_get v2, index u32 1 -> Field
v52 = eq v51, Field 0
v53 = not v52
enable_side_effects v53
v54 = array_get v2, index u32 1 -> Field
v55 = lt v49, u32 4
v56 = mul v55, v53
constrain v56 == v53
v57 = lt v49, u32 4
v58 = mul v57, v53
constrain v58 == v53
v59 = array_set v48, index v49, value v54
v60 = add v49, u32 1
v61 = if v53 then v59 else (if v52) v48
v62 = cast v53 as u32
v63 = cast v52 as u32
v64 = unchecked_mul v62, v60
v65 = unchecked_mul v63, v49
v66 = unchecked_add v64, v65
enable_side_effects u1 1
v67 = array_get v37, index u32 0 -> Field
v68 = array_get v37, index u32 1 -> Field
v69 = array_get v37, index u32 2 -> Field
v71 = array_get v37, index u32 3 -> Field
v72 = array_get v61, index u32 0 -> Field
v73 = array_get v61, index u32 1 -> Field
v74 = array_get v61, index u32 2 -> Field
v75 = array_get v61, index u32 3 -> Field
v76 = make_array [v67, v68, v69, v71, v72, v73, v74, v75] : [Field; 8]
return v76
}
";
let ssa = Ssa::from_str(src).unwrap();
let ssa = ssa.remove_if_else();
assert_ssa_snapshot!(ssa, @r"
g0 = u32 2

acir(inline) predicate_pure fn main f0 {
b0(v1: [Field; 2], v2: [Field; 2]):
v4 = array_get v1, index u32 0 -> Field
v6 = array_get v1, index u32 1 -> Field
v7 = array_get v2, index u32 0 -> Field
v8 = array_get v2, index u32 1 -> Field
v9 = make_array [v4, v6, v7, v8] : [Field; 4]
v11 = make_array [Field 0, Field 0, Field 0, Field 0] : [Field; 4]
v12 = make_array [Field 0, Field 0, Field 0, Field 0] : [Field; 4]
v13 = allocate -> &mut [Field; 4]
v14 = allocate -> &mut u32
v15 = allocate -> &mut [Field; 4]
v16 = allocate -> &mut u32
v17 = array_get v1, index u32 0 -> Field
v18 = eq v17, Field 0
v19 = not v18
enable_side_effects v19
v20 = array_get v1, index u32 0 -> Field
v21 = make_array [v20, Field 0, Field 0, Field 0] : [Field; 4]
v22 = cast v19 as Field
v23 = cast v18 as Field
v24 = mul v22, v20
v25 = make_array [v24, Field 0, Field 0, Field 0] : [Field; 4]
v26 = cast v19 as u32
v27 = cast v18 as u32
enable_side_effects u1 1
v29 = array_get v1, index u32 1 -> Field
v30 = eq v29, Field 0
v31 = not v30
enable_side_effects v31
v32 = array_get v1, index u32 1 -> Field
v34 = lt v26, u32 4
v35 = mul v34, v31
constrain v35 == v31
v36 = lt v26, u32 4
v37 = mul v36, v31
constrain v37 == v31
v38 = array_set v25, index v26, value v32
v39 = add v26, u32 1
enable_side_effects v31
v40 = array_get v38, index v26 -> Field
v41 = array_get v25, index v26 -> Field
v42 = cast v31 as Field
v43 = cast v30 as Field
v44 = mul v42, v40
v45 = mul v43, v41
v46 = add v44, v45
v47 = array_set v38, index v26, value v46
enable_side_effects v31
v48 = cast v31 as u32
v49 = cast v30 as u32
v50 = unchecked_mul v48, v39
v51 = unchecked_mul v49, v26
v52 = unchecked_add v50, v51
enable_side_effects u1 1
v53 = array_get v2, index u32 0 -> Field
v54 = eq v53, Field 0
v55 = not v54
enable_side_effects v55
v56 = array_get v2, index u32 0 -> Field
v57 = make_array [v56, Field 0, Field 0, Field 0] : [Field; 4]
v58 = cast v55 as Field
v59 = cast v54 as Field
v60 = mul v58, v56
v61 = make_array [v60, Field 0, Field 0, Field 0] : [Field; 4]
v62 = cast v55 as u32
v63 = cast v54 as u32
enable_side_effects u1 1
v64 = array_get v2, index u32 1 -> Field
v65 = eq v64, Field 0
v66 = not v65
enable_side_effects v66
v67 = array_get v2, index u32 1 -> Field
v68 = lt v62, u32 4
v69 = mul v68, v66
constrain v69 == v66
v70 = lt v62, u32 4
v71 = mul v70, v66
constrain v71 == v66
v72 = array_set v61, index v62, value v67
v73 = add v62, u32 1
enable_side_effects v66
v74 = array_get v72, index v62 -> Field
v75 = array_get v61, index v62 -> Field
v76 = cast v66 as Field
v77 = cast v65 as Field
v78 = mul v76, v74
v79 = mul v77, v75
v80 = add v78, v79
v81 = array_set v72, index v62, value v80
enable_side_effects v66
v82 = cast v66 as u32
v83 = cast v65 as u32
v84 = unchecked_mul v82, v73
v85 = unchecked_mul v83, v62
v86 = unchecked_add v84, v85
enable_side_effects u1 1
v87 = array_get v47, index u32 0 -> Field
v88 = array_get v47, index u32 1 -> Field
v89 = array_get v47, index u32 2 -> Field
v91 = array_get v47, index u32 3 -> Field
v92 = array_get v81, index u32 0 -> Field
v93 = array_get v81, index u32 1 -> Field
v94 = array_get v81, index u32 2 -> Field
v95 = array_get v81, index u32 3 -> Field
v96 = make_array [v87, v88, v89, v91, v92, v93, v94, v95] : [Field; 8]
return v96
}
");
}
}
Loading