chore!: several ACIR serialisation changes

.github/workflows/test-js-packages.yml

@@ -512,54 +512,56 @@ jobs:
         run: |
           yarn test:node
 
-  test-integration-browser:
-    name: Integration Tests (Browser)
-    runs-on: ubuntu-22.04
-    needs: [build-acvm-js, build-noir-wasm, build-noirc-abi]
-    timeout-minutes: 30
-    permissions:
-      contents: read
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v5
-
-      - name: Download acvm_js package artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: acvm-js
-          path: ./acvm-repo/acvm_js
-
-      - name: Download noir_wasm package artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: noir_wasm
-          path: ./compiler/wasm
-
-      - name: Download noirc_abi package artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: noirc_abi_wasm
-          path: ./tooling/noirc_abi_wasm
-
-      - name: Install Yarn dependencies
-        uses: ./.github/actions/setup
-
-      - uses: taiki-e/install-action@just
-
-      - name: Install Playwright
-        run: just install-playwright
-
-      - name: Setup `integration-tests`
-        run: |
-          # Note the lack of spaces between package names.
-          PACKAGES_TO_BUILD="@noir-lang/types,@noir-lang/noir_js"
-          yarn workspaces foreach -Wvtp --from "{$PACKAGES_TO_BUILD}" run build
-
-      - name: Run `integration-tests`
-        working-directory: ./compiler/integration-tests
-        run: |
-          yarn test:browser
+  # TODO(https://github.com/noir-lang/noir/issues/9935): These tests are currently broken as they are currently written
+  # We have other browser tests under `examples/browser`, but it would be good to get these working again.
+  # test-integration-browser:
+  #   name: Integration Tests (Browser)
+  #   runs-on: ubuntu-22.04
+  #   needs: [build-acvm-js, build-noir-wasm, build-noirc-abi]
+  #   timeout-minutes: 30
+  #   permissions:
+  #     contents: read
+
+  #   steps:
+  #     - name: Checkout
+  #       uses: actions/checkout@v5
+
+  #     - name: Download acvm_js package artifact
+  #       uses: actions/download-artifact@v4
+  #       with:
+  #         name: acvm-js
+  #         path: ./acvm-repo/acvm_js
+
+  #     - name: Download noir_wasm package artifact
+  #       uses: actions/download-artifact@v4
+  #       with:
+  #         name: noir_wasm
+  #         path: ./compiler/wasm
+
+  #     - name: Download noirc_abi package artifact
+  #       uses: actions/download-artifact@v4
+  #       with:
+  #         name: noirc_abi_wasm
+  #         path: ./tooling/noirc_abi_wasm
+
+  #     - name: Install Yarn dependencies
+  #       uses: ./.github/actions/setup
+
+  #     - uses: taiki-e/install-action@just
+
+  #     - name: Install Playwright
+  #       run: just install-playwright
+
+  #     - name: Setup `integration-tests`
+  #       run: |
+  #         # Note the lack of spaces between package names.
+  #         PACKAGES_TO_BUILD="@noir-lang/types,@noir-lang/noir_js"
+  #         yarn workspaces foreach -Wvtp --from "{$PACKAGES_TO_BUILD}" run build
+
+  #     - name: Run `integration-tests`
+  #       working-directory: ./compiler/integration-tests
+  #       run: |
+  #         yarn test:browser
 
   test-examples:
     name: Example scripts
@@ -801,7 +803,7 @@ jobs:
       - test-noir-wasm
       - test-noir-codegen
       - test-integration-node
-      - test-integration-browser
+      #- test-integration-browser
       - test-examples
       - compile-noir-contracts
     permissions:

EXTERNAL_NOIR_LIBRARIES.yml

@@ -46,7 +46,7 @@ libraries:
     critical: true
   sparse_array:
     repo: noir-lang/sparse_array
-    timeout: 3
+    timeout: 10
     critical: false
   noir_json_parser:
     repo: noir-lang/noir_json_parser

acvm-repo/acir/benches/serialization.rs

@@ -3,7 +3,7 @@ use std::{collections::BTreeSet, time::Duration};
 
 use acir::{
     FieldElement,
-    circuit::{Circuit, ExpressionWidth, Opcode, Program, PublicInputs},
+    circuit::{Circuit, Opcode, Program, PublicInputs},
     native_types::{Expression, Witness},
 };
 
@@ -31,9 +31,9 @@ fn sample_program(num_opcodes: usize) -> Program<FieldElement> {
 
     Program {
         functions: vec![Circuit {
+            function_name: "main".to_string(),
             current_witness_index: 4000,
             opcodes: assert_zero_opcodes.to_vec(),
-            expression_width: ExpressionWidth::Bounded { width: 4 },
             private_parameters: BTreeSet::from([Witness(1), Witness(2), Witness(3), Witness(4)]),
             public_parameters: PublicInputs(BTreeSet::from([Witness(5)])),
             return_values: PublicInputs(BTreeSet::from([Witness(6)])),