fix: Don't skip for loops with negative literal ranges#8103
Merged
aakoshh merged 12 commits intoaf/8009-fix-range-modulofrom Apr 22, 2025
Merged
fix: Don't skip for loops with negative literal ranges#8103aakoshh merged 12 commits intoaf/8009-fix-range-modulofrom
aakoshh merged 12 commits intoaf/8009-fix-range-modulofrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 02d81e0 | Previous: 3024dd3 | Ratio |
|---|---|---|---|
rollup-block-root |
16.2 s |
11.5 s |
1.41 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
michaeljklein
approved these changes
Apr 16, 2025
Contributor
michaeljklein
left a comment
michaeljklein
left a comment
There was a problem hiding this comment.
LGTM
While looking for bugs, I found an unrelated panic when u1 is used as a for loop range: #8107
asterite
reviewed
Apr 16, 2025
…f/8011-for-negative-range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #8011
Summary*
Fixes
codegen_forto usetry_convert_field_element_to_signed_integerinstead of comparing theFieldrepresentations of the loop boundaries.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.