chore: don't use set_value_from_id in simplify_cfg#8059
Closed
chore: don't use set_value_from_id in simplify_cfg#8059
set_value_from_id in simplify_cfg#8059Conversation
Collaborator
Author
|
I'll close this PR and create a new one once the base PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #8039
Description
Problem
Slowly trying to migrate away from
set_value_from_idSummary
I realized that I wasn't solving values recursively (that is, if we need to replace
v0withv1andv1withv2we need to replacev0withv2) so I'll backport this change to #8039 too.Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.