Skip to content

chore: remove unnecessary double compilation #8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Apr 11, 2025
Merged

chore: remove unnecessary double compilation #8031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions compiler/noirc_driver/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,6 @@ pub struct CompileOptions {
#[arg(long, default_value = "false")]
pub pedantic_solving: bool,

/// Used internally to test for non-determinism in the compiler.
#[clap(long, hide = true)]
pub check_non_determinism: bool,

/// Unstable features to enable for this current build
#[arg(value_parser = clap::value_parser!(UnstableFeature))]
#[clap(long, short = 'Z', value_delimiter = ',')]
Expand Down
17 changes: 0 additions & 17 deletions tooling/nargo_cli/src/cli/compile_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
fn watch_workspace(workspace: &Workspace, compile_options: &CompileOptions) -> notify::Result<()> {
let (tx, rx) = std::sync::mpsc::channel();

// No specific tickrate, max debounce time 1 seconds

Check warning on line 67 in tooling/nargo_cli/src/cli/compile_cmd.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (tickrate)
let mut debouncer = new_debouncer(Duration::from_secs(1), None, tx)?;

// Add a path to be watched. All files and directories at that path and
Expand Down Expand Up @@ -206,23 +206,6 @@
cached_program,
)?;

if compile_options.check_non_determinism {
// As we compile the program again, disable comptime printing so we don't get duplicate output
let compile_options =
CompileOptions { disable_comptime_printing: true, ..compile_options.clone() };
let (program_two, _) = compile_program(
file_manager,
parsed_files,
workspace,
package,
&compile_options,
load_cached_program(package),
)?;
if fxhash::hash64(&program) != fxhash::hash64(&program_two) {
panic!("Non deterministic result compiling {}", package.name);
}
}

// Choose the target width for the final, backend specific transformation.
let target_width =
get_target_width(package.expression_width, compile_options.expression_width);
Expand Down
2 changes: 0 additions & 2 deletions tooling/nargo_cli/tests/execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,12 @@
nargo.arg("--program-dir").arg(test_program_dir);
nargo.arg(test_command).arg("--force");
nargo.arg("--inliner-aggressiveness").arg(inliner_aggressiveness.0.to_string());
// Check whether the test case is non-deterministic
nargo.arg("--check-non-determinism");
// Allow more bytecode in exchange to catch illegal states.
nargo.arg("--enable-brillig-debug-assertions");

// Enable enums and ownership as unstable features
nargo.arg("-Zenums");

Check warning on line 38 in tooling/nargo_cli/tests/execute.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (Zenums)
nargo.arg("-Zownership");

Check warning on line 39 in tooling/nargo_cli/tests/execute.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (Zownership)

if force_brillig.0 {
{
Expand Down
Loading