Skip to content

feat: use batch inversion when writing to the witness map (WIP)#8028

Closed
kashbrti wants to merge 15 commits intomasterfrom
kb/acvm_batch_invert
Closed

feat: use batch inversion when writing to the witness map (WIP)#8028
kashbrti wants to merge 15 commits intomasterfrom
kb/acvm_batch_invert

Conversation

@kashbrti
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Khashayar Barooti added 2 commits April 11, 2025 15:50
@kashbrti
Copy link
Contributor Author

@TomAFrench this pr is still way too far from being ready to review. Would be better to wait a bit before checking it

@TomAFrench
Copy link
Member

Yep, was just following up providing links to things I had spoken about previously.

@TomAFrench TomAFrench marked this pull request as draft April 11, 2025 16:51
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: d8e4681 Previous: 28250ea Ratio
rollup-merge 0.004 s 0.003 s 1.33

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: d8e4681 Previous: 28250ea Ratio
test_report_noir-lang_noir-bignum_ 515 s 411 s 1.25

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench
Copy link
Member

I'm going to close this PR as it looks like we weren't generating constraints which would benefit from it.

@TomAFrench TomAFrench closed this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants