Skip to content

chore: redo typo PR by MalgAmoe#7960

Closed
TomAFrench wants to merge 1 commit intomasterfrom
chore/typo-redo-7921
Closed

chore: redo typo PR by MalgAmoe#7960
TomAFrench wants to merge 1 commit intomasterfrom
chore/typo-redo-7921

Conversation

@TomAFrench
Copy link
Member

Thanks MalgAmoe for #7921. Our policy is to redo typo changes to dissuade metric farming. This is an automated script.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Changes to number of Brillig opcodes executed

Generated at commit: ddab549cfa88fe1bb2a1fce76e4fc412f8638cd7, compared to commit: e13142b000d75b81d1e0e9d92236d8a040631ec9

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
array_to_slice_inliner_max +428 ❌ +39.34%
slices_inliner_max +507 ❌ +19.30%
slices_inliner_zero +498 ❌ +17.63%
modulus_inliner_min +634 ❌ +4.27%

Full diff report 👇
Program Brillig opcodes (+/-) %
array_to_slice_inliner_max 1,516 (+428) +39.34%
slices_inliner_max 3,134 (+507) +19.30%
slices_inliner_zero 3,323 (+498) +17.63%
modulus_inliner_min 15,472 (+634) +4.27%
modulus_inliner_max 15,422 (+604) +4.08%
modulus_inliner_zero 15,422 (+604) +4.08%
hint_black_box_inliner_max 615 (+10) +1.65%
regression_5252_inliner_max 851,067 (+12,090) +1.44%
poseidonsponge_x5_254_inliner_max 170,897 (+2,410) +1.43%
fold_numeric_generic_poseidon_inliner_zero 5,610 (+60) +1.08%
no_predicates_numeric_generic_poseidon_inliner_zero 5,610 (+60) +1.08%
fold_2_to_17_inliner_max 1,056,631 (+9,320) +0.89%
bench_2_to_17_inliner_max 570,235 (+4,900) +0.87%
bench_2_to_17_inliner_zero 609,450 (+4,900) +0.81%
poseidon_bn254_hash_width_3_inliner_max 150,934 (+1,205) +0.80%
poseidon_bn254_hash_width_3_inliner_zero 181,451 (+1,206) +0.67%
fold_numeric_generic_poseidon_inliner_max 4,767 (+30) +0.63%
no_predicates_numeric_generic_poseidon_inliner_max 4,767 (+30) +0.63%
uhashmap_inliner_max 128,284 (+354) +0.28%
uhashmap_inliner_zero 163,202 (+350) +0.21%
uhashmap_inliner_min 183,015 (+350) +0.19%
hashmap_inliner_max 48,194 (+24) +0.05%
hashmap_inliner_zero 72,450 (+24) +0.03%
regression_5252_inliner_zero 1,004,869 (+40) +0.00%
loop_invariant_regression_inliner_min 1,067 (-22) -2.02%
loop_invariant_regression_inliner_max 379 (-8) -2.07%
loop_invariant_regression_inliner_zero 379 (-8) -2.07%

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Changes to Brillig bytecode sizes

Generated at commit: ddab549cfa88fe1bb2a1fce76e4fc412f8638cd7, compared to commit: e13142b000d75b81d1e0e9d92236d8a040631ec9

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
array_to_slice_inliner_max +113 ❌ +22.92%
loop_invariant_regression_inliner_max -25 ✅ -15.72%
loop_invariant_regression_inliner_zero -25 ✅ -15.72%
loop_invariant_regression_inliner_min -35 ✅ -16.36%

Full diff report 👇
Program Brillig opcodes (+/-) %
array_to_slice_inliner_max 606 (+113) +22.92%
slices_inliner_zero 1,851 (+211) +12.87%
slices_inliner_max 1,951 (+219) +12.64%
poseidonsponge_x5_254_inliner_max 4,107 (+55) +1.36%
regression_5252_inliner_max 4,446 (+57) +1.30%
hint_black_box_inliner_max 314 (+4) +1.29%
fold_numeric_generic_poseidon_inliner_zero 560 (+6) +1.08%
no_predicates_numeric_generic_poseidon_inliner_zero 560 (+6) +1.08%
uhashmap_inliner_max 11,399 (+104) +0.92%
fold_2_to_17_inliner_max 560 (+4) +0.72%
bench_2_to_17_inliner_zero 287 (+2) +0.70%
poseidon_bn254_hash_width_3_inliner_zero 4,656 (+30) +0.65%
bench_2_to_17_inliner_max 317 (+2) +0.63%
modulus_inliner_max 1,716 (+10) +0.59%
modulus_inliner_zero 1,716 (+10) +0.59%
poseidon_bn254_hash_width_3_inliner_max 5,242 (+29) +0.56%
fold_numeric_generic_poseidon_inliner_max 726 (+4) +0.55%
no_predicates_numeric_generic_poseidon_inliner_max 726 (+4) +0.55%
modulus_inliner_min 1,731 (+8) +0.46%
uhashmap_inliner_zero 6,699 (+26) +0.39%
uhashmap_inliner_min 7,372 (+26) +0.35%
regression_5252_inliner_zero 3,399 (+2) +0.06%
loop_invariant_regression_inliner_max 134 (-25) -15.72%
loop_invariant_regression_inliner_zero 134 (-25) -15.72%
loop_invariant_regression_inliner_min 179 (-35) -16.36%

@TomAFrench TomAFrench closed this Apr 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

FYI @noir-lang/developerrelations on Noir doc changes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: cbd14c5 Previous: e13142b Ratio
zkemail_zkemail.nr_lib 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant