chore(patch): Make public inputs the start of the UH and MH proof #12266#7706
Closed
chore(patch): Make public inputs the start of the UH and MH proof #12266#7706
Conversation
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Mar 14, 2025
Contains the changes from #12574 to replace the copy of the noir-repo with a `noir-repo-ref` file to point at the nightly version which we pull during the build. Updated `noir-repo-ref` in the PR to match the last merge sync PR #12624 Alternatively it could be set to include the commits from the open #12669 by setting it to [nightly-2025-03-14](https://github.com/noir-lang/noir/commits/nightly-2025-03-14) Added a patch to replicate the changes to honk test programs in #12266 Opened noir-lang/noir#7706 to migrate the patch back to Noir --------- Co-authored-by: Akosh Farkash <aakoshh@gmail.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: aakoshh <akosh@aztecprotocol.com>
AztecBot
pushed a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Mar 15, 2025
Contains the changes from AztecProtocol/aztec-packages#12574 to replace the copy of the noir-repo with a `noir-repo-ref` file to point at the nightly version which we pull during the build. Updated `noir-repo-ref` in the PR to match the last merge sync PR AztecProtocol/aztec-packages#12624 Alternatively it could be set to include the commits from the open AztecProtocol/aztec-packages#12669 by setting it to [nightly-2025-03-14](https://github.com/noir-lang/noir/commits/nightly-2025-03-14) Added a patch to replicate the changes to honk test programs in AztecProtocol/aztec-packages#12266 Opened noir-lang/noir#7706 to migrate the patch back to Noir --------- Co-authored-by: Akosh Farkash <aakoshh@gmail.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: aakoshh <akosh@aztecprotocol.com>
Member
|
Closing as these files have been removed in a different PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Upstream test program changes from AztecProtocol/aztec-packages#12266
Summary*
Got some build failures in AztecProtocol/aztec-packages#12592 due to changes made to the honk test programs 2 days ago. I added a patch file in that PR. This PR is bringing the changes in that patch file back to noir.
Additional Context
To create the patch file, I made the fixes based on the changes in 12266 in my local checkout of
noir/noir-repo, then did the following:The way to bring it back was something like this:
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.