Skip to content

chore(patch): Make public inputs the start of the UH and MH proof #12266#7706

Closed
aakoshh wants to merge 2 commits intomasterfrom
af/patch-12266
Closed

chore(patch): Make public inputs the start of the UH and MH proof #12266#7706
aakoshh wants to merge 2 commits intomasterfrom
af/patch-12266

Conversation

@aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Mar 14, 2025

Description

Problem*

Upstream test program changes from AztecProtocol/aztec-packages#12266

Summary*

Got some build failures in AztecProtocol/aztec-packages#12592 due to changes made to the honk test programs 2 days ago. I added a patch file in that PR. This PR is bringing the changes in that patch file back to noir.

Additional Context

To create the patch file, I made the fixes based on the changes in 12266 in my local checkout of noir/noir-repo, then did the following:

cd noir/noir-repo
git add . 
git commit -m "patch: Make public inputs the start of the UH and MH proof #12266"
cd ..
scripts/sync.sh make-patch
git add noir-repo.patch
git commit -m "patch file for #12266"

The way to bring it back was something like this:

cd noir/noir-repo
git checkout -b af/patch-12266
# Get rid the fixup and empty patch marker commits
git rebase -i $(cat ../noir-repo-ref)
git remote add upstream git@github.com:noir-lang/noir.git
git push --set-upstream upstream af/patch-12266
cd ..
# Now re-apply the fixup 
scripts/sync.sh update

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@aakoshh aakoshh changed the title patch: Make public inputs the start of the UH and MH proof #12266 chore(patch): Make public inputs the start of the UH and MH proof #12266 Mar 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

Changes to number of Brillig opcodes executed

Generated at commit: ef8b63ff5714eb7c90f98cfbcc3c23d81497a755, compared to commit: c30bcd7e753d835442187bb27a6c14231041ed77

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
double_verify_honk_proof_inliner_max -42 ✅ -0.57%
double_verify_honk_proof_inliner_min -42 ✅ -0.57%
double_verify_honk_proof_inliner_zero -42 ✅ -0.57%

Full diff report 👇
Program Brillig opcodes (+/-) %
verify_rollup_honk_proof_inliner_max 4,799 (-21) -0.44%
verify_rollup_honk_proof_inliner_min 4,799 (-21) -0.44%
verify_rollup_honk_proof_inliner_zero 4,799 (-21) -0.44%
verify_honk_proof_inliner_max 4,169 (-21) -0.50%
verify_honk_proof_inliner_min 4,169 (-21) -0.50%
verify_honk_proof_inliner_zero 4,169 (-21) -0.50%
double_verify_honk_proof_inliner_max 7,379 (-42) -0.57%
double_verify_honk_proof_inliner_min 7,379 (-42) -0.57%
double_verify_honk_proof_inliner_zero 7,379 (-42) -0.57%

@aakoshh aakoshh requested a review from TomAFrench March 14, 2025 10:49
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request Mar 14, 2025
Contains the changes from
#12574 to replace
the copy of the noir-repo with a `noir-repo-ref` file to point at the
nightly version which we pull during the build.

Updated `noir-repo-ref` in the PR to match the last merge sync PR
#12624
Alternatively it could be set to include the commits from the open
#12669 by setting it
to
[nightly-2025-03-14](https://github.com/noir-lang/noir/commits/nightly-2025-03-14)

Added a patch to replicate the changes to honk test programs in
#12266
Opened noir-lang/noir#7706 to migrate the patch
back to Noir

---------

Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: aakoshh <akosh@aztecprotocol.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this pull request Mar 15, 2025
Contains the changes from
AztecProtocol/aztec-packages#12574 to replace
the copy of the noir-repo with a `noir-repo-ref` file to point at the
nightly version which we pull during the build.

Updated `noir-repo-ref` in the PR to match the last merge sync PR
AztecProtocol/aztec-packages#12624
Alternatively it could be set to include the commits from the open
AztecProtocol/aztec-packages#12669 by setting it
to
[nightly-2025-03-14](https://github.com/noir-lang/noir/commits/nightly-2025-03-14)

Added a patch to replicate the changes to honk test programs in
AztecProtocol/aztec-packages#12266
Opened noir-lang/noir#7706 to migrate the patch
back to Noir

---------

Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: aakoshh <akosh@aztecprotocol.com>
@TomAFrench
Copy link
Member

TomAFrench commented Mar 19, 2025

Closing as these files have been removed in a different PR.

@TomAFrench TomAFrench closed this Mar 19, 2025
@aakoshh aakoshh deleted the af/patch-12266 branch June 3, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants