Skip to content

feat: optimize out range checks on limiting cases #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Feb 25, 2025
Merged

feat: optimize out range checks on limiting cases #7510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion compiler/noirc_evaluator/src/ssa/ir/instruction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ impl Instruction {
Instruction::DecrementRc { .. } => None,
Instruction::RangeCheck { value, max_bit_size, .. } => {
let max_potential_bits = dfg.get_value_max_num_bits(*value);
if max_potential_bits < *max_bit_size {
if max_potential_bits <= *max_bit_size {
Remove
} else {
None
Expand Down Expand Up @@ -1472,3 +1472,32 @@ impl SimplifyResult {
}
}
}

#[cfg(test)]
mod tests {
use crate::ssa::{opt::assert_normalized_ssa_equals, ssa_gen::Ssa};

#[test]
fn removes_range_constraints_on_constants() {
let src = "
acir(inline) fn main f0 {
b0(v0: Field):
range_check Field 0 to 1 bits
range_check Field 1 to 1 bits
range_check Field 255 to 8 bits
range_check Field 256 to 8 bits
return
}
";
let ssa = Ssa::from_str_simplifying(src).unwrap();

let expected = "
acir(inline) fn main f0 {
b0(v0: Field):
range_check Field 256 to 8 bits
return
}
";
assert_normalized_ssa_equals(ssa, expected);
}
}