Skip to content

feat(experimental): Always inline certain methods in sha #7364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vezenovm wants to merge 2 commits into from
Closed

feat(experimental): Always inline certain methods in sha #7364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99beecc
add inline_always to certain method in sha
vezenovm Feb 13, 2025
d4baab7
a couple more inline_always
vezenovm Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions noir_stdlib/src/hash/sha256.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ fn update_block_item<Env>(
}

// Set the rightmost `zeros` number of bytes to 0.
#[inline_always]
fn set_item_zeros(item: u32, zeros: u8) -> u32 {
lshift8(rshift8(item, zeros), zeros)
}
Expand All @@ -374,6 +375,7 @@ fn get_item_byte(mut msg_item: u32, msg_byte_ptr: BLOCK_BYTE_PTR) -> u8 {
// Project a byte into a position in a field based on the overall block pointer.
// For example putting 1 into pointer 5 would be 100, because overall we would
// have [____, 0100] with indexes [0123,4567].
#[inline_always]
fn byte_into_item(msg_byte: u8, msg_byte_ptr: BLOCK_BYTE_PTR) -> u32 {
let mut msg_item = msg_byte as u32;
// How many times do we have to shift to the left to get to the position we want?
Expand All @@ -383,6 +385,7 @@ fn byte_into_item(msg_byte: u8, msg_byte_ptr: BLOCK_BYTE_PTR) -> u32 {
}

// Construct a field out of 4 bytes.
#[inline_always]
fn make_item(b0: u8, b1: u8, b2: u8, b3: u8) -> u32 {
let mut item = b0 as u32;
item = lshift8(item, 1) + b1 as u32;
Expand All @@ -394,6 +397,7 @@ fn make_item(b0: u8, b1: u8, b2: u8, b3: u8) -> u32 {
// Shift by 8 bits to the left between 0 and 4 times.
// Checks `is_unconstrained()` to just use a bitshift if we're running in an unconstrained context,
// otherwise multiplies by 256.
#[inline_always]
fn lshift8(item: u32, shifts: u8) -> u32 {
if is_unconstrained() {
if item == 0 {
Expand Down