feat: while statement by asterite · Pull Request #7280 · noir-lang/noir

asterite · 2025-02-04T20:43:36Z

Description

Problem

Summary

Similar to while in Rust

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2025-02-04T20:53:05Z

🚀 Deployed on https://67b3434acebd6211b525975a--noir-docs.netlify.app

compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs

michaeljklein

LGTM besides the formatter test

tooling/nargo_fmt/src/formatter/statement.rs

Co-authored-by: Michael J Klein <michaeljklein@users.noreply.github.com>

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `cd671dd`	Previous: `058d1b0`	Ratio
``	`587.74` MB	`272.08` MB	`2.16`
``	`1170` MB	`272.08` MB	`4.30`
``	`2180` MB	`272.08` MB	`8.01`
``	`662.7` MB	`272.08` MB	`2.44`
``	`547.15` MB	`272.08` MB	`2.01`
``	`5310` MB	`272.08` MB	`19.52`
``	`5320` MB	`272.08` MB	`19.55`
``	`545.56` MB	`272.08` MB	`2.01`
``	`662.7` MB	`272.08` MB	`2.44`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `cd671dd`	Previous: `058d1b0`	Ratio
``	`652.28` MB	`213.15` MB	`3.06`
``	`793.63` MB	`213.15` MB	`3.72`
``	`555.92` MB	`213.15` MB	`2.61`
``	`1230` MB	`213.15` MB	`5.77`
``	`529.89` MB	`213.15` MB	`2.49`
``	`555.9` MB	`213.15` MB	`2.61`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

michaeljklein

LGTM

I think #7311 may have caused memory reports to say all previous values are 272.08 MB.

compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs

Co-authored-by: Akosh Farkash <aakoshh@gmail.com>

tooling/nargo_fmt/src/formatter/statement.rs

github-actions · 2025-02-17T14:08:45Z

FYI @noir-lang/developerrelations on Noir doc changes.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `c76527b`	Previous: `b7ace68`	Ratio
`AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib`	`216` s	`152` s	`1.42`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

…m brillig (noir-lang/noir#7434) chore(docs): updating tutorials and other nits to beta.2 (noir-lang/noir#7405) feat: LSP hover for integer literals (noir-lang/noir#7368) feat(experimental): Compile match expressions (noir-lang/noir#7312) feat(acir_field): Add little-endian byte serialization for FieldElement (noir-lang/noir#7258) feat: allow unquoting TraitConstraint in trait impl position (noir-lang/noir#7395) feat(brillig): Hoist shared constants across functions to the global space (noir-lang/noir#7216) feat(LSP): auto-import via visible reexport (noir-lang/noir#7409) fix(brillig): Brillig entry point analysis and function specialization through duplication (noir-lang/noir#7277) chore: redo typo PR by maximevtush (noir-lang/noir#7425) fix(ssa): Accurately mark binary ops for hoisting and check Div/Mod against induction variable lower bound (noir-lang/noir#7396) feat!: remove bigint from stdlib (noir-lang/noir#7411) chore: bump aztec-packages commit (noir-lang/noir#7415) chore: deprecate `merkle` module of stdlib (noir-lang/noir#7413) chore(ci): lock aztec-packages commit in CI (noir-lang/noir#7414) feat: while statement (noir-lang/noir#7280)

…oir-lang/noir#7434) chore(docs): updating tutorials and other nits to beta.2 (noir-lang/noir#7405) feat: LSP hover for integer literals (noir-lang/noir#7368) feat(experimental): Compile match expressions (noir-lang/noir#7312) feat(acir_field): Add little-endian byte serialization for FieldElement (noir-lang/noir#7258) feat: allow unquoting TraitConstraint in trait impl position (noir-lang/noir#7395) feat(brillig): Hoist shared constants across functions to the global space (noir-lang/noir#7216) feat(LSP): auto-import via visible reexport (noir-lang/noir#7409) fix(brillig): Brillig entry point analysis and function specialization through duplication (noir-lang/noir#7277) chore: redo typo PR by maximevtush (noir-lang/noir#7425) fix(ssa): Accurately mark binary ops for hoisting and check Div/Mod against induction variable lower bound (noir-lang/noir#7396) feat!: remove bigint from stdlib (noir-lang/noir#7411) chore: bump aztec-packages commit (noir-lang/noir#7415) chore: deprecate `merkle` module of stdlib (noir-lang/noir#7413) chore(ci): lock aztec-packages commit in CI (noir-lang/noir#7414) feat: while statement (noir-lang/noir#7280)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(performance): Remove redundant slice access check from brillig (noir-lang/noir#7434) chore(docs): updating tutorials and other nits to beta.2 (noir-lang/noir#7405) feat: LSP hover for integer literals (noir-lang/noir#7368) feat(experimental): Compile match expressions (noir-lang/noir#7312) feat(acir_field): Add little-endian byte serialization for FieldElement (noir-lang/noir#7258) feat: allow unquoting TraitConstraint in trait impl position (noir-lang/noir#7395) feat(brillig): Hoist shared constants across functions to the global space (noir-lang/noir#7216) feat(LSP): auto-import via visible reexport (noir-lang/noir#7409) fix(brillig): Brillig entry point analysis and function specialization through duplication (noir-lang/noir#7277) chore: redo typo PR by maximevtush (noir-lang/noir#7425) fix(ssa): Accurately mark binary ops for hoisting and check Div/Mod against induction variable lower bound (noir-lang/noir#7396) feat!: remove bigint from stdlib (noir-lang/noir#7411) chore: bump aztec-packages commit (noir-lang/noir#7415) chore: deprecate `merkle` module of stdlib (noir-lang/noir#7413) chore(ci): lock aztec-packages commit in CI (noir-lang/noir#7414) feat: while statement (noir-lang/noir#7280) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>

feat: while statement

7066452

github-actions bot added the documentation Improvements or additions to documentation label Feb 4, 2025

asterite added 2 commits February 4, 2025 17:46

Also have While node on the monomorphizer side

8c49171

Fix name of example program

20d13f8

asterite marked this pull request as ready for review February 4, 2025 21:34

asterite requested a review from a team February 5, 2025 11:52

TomAFrench reviewed Feb 5, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs Show resolved Hide resolved

michaeljklein suggested changes Feb 6, 2025

View reviewed changes

tooling/nargo_fmt/src/formatter/statement.rs Show resolved Hide resolved

asterite and others added 2 commits February 6, 2025 12:32

Update tooling/nargo_fmt/src/formatter/statement.rs

f883864

Co-authored-by: Michael J Klein <michaeljklein@users.noreply.github.com>

fix

cd671dd

github-actions bot reviewed Feb 6, 2025

View reviewed changes

michaeljklein approved these changes Feb 7, 2025

View reviewed changes

Merge branch 'master' into ab/while

f961101

aakoshh reviewed Feb 11, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs Outdated Show resolved Hide resolved

Update compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs

e526230

Co-authored-by: Akosh Farkash <aakoshh@gmail.com>

TomAFrench reviewed Feb 11, 2025

View reviewed changes

tooling/nargo_fmt/src/formatter/statement.rs Show resolved Hide resolved

asterite enabled auto-merge February 17, 2025 13:38

asterite added this pull request to the merge queue Feb 17, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025

Merge branch 'master' into ab/while

5527436

TomAFrench enabled auto-merge February 17, 2025 13:58

TomAFrench disabled auto-merge February 17, 2025 13:59

.

c76527b

TomAFrench enabled auto-merge February 17, 2025 14:00

github-actions bot reviewed Feb 17, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Feb 17, 2025

Merged via the queue into master with commit 582f56e Feb 17, 2025
103 checks passed

TomAFrench deleted the ab/while branch February 17, 2025 14:27

noirwhal mentioned this pull request Feb 17, 2025

chore: Release Noir(1.0.0-beta.3) #7346

Merged

AztecBot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Feb 18, 2025

[1 changes] feat: while statement (noir-lang/noir#7280)

9d770c8

AztecBot mentioned this pull request Feb 18, 2025

feat: Sync from noir AztecProtocol/aztec-packages#12064

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: while statement#7280

feat: while statement#7280
TomAFrench merged 9 commits intomasterfrom
ab/while

asterite commented Feb 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

michaeljklein left a comment

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

michaeljklein left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

asterite commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Summary

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

michaeljklein left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

michaeljklein left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

asterite commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025 •

edited

Loading