feat: array concat method by iAmMichaelConnor · Pull Request #7199 · noir-lang/noir

iAmMichaelConnor · 2025-01-27T20:21:55Z

Description

Add a concat method to the stdlib for the array type.

Where are the array tests? Where should I put a test for this method? Edit: I've put the test in the same file (despite not seeing tests for the other array methods there)

Problem*

Summary*

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `d161a0d`	Previous: `4fe4cc6`	Ratio
`sha256_regression`	`0.076` s	`0.051` s	`1.49`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions · 2025-01-27T20:31:59Z

🚀 Deployed on https://67b6fe5639d8c84ea9a5c283--noir-docs.netlify.app

docs/docs/noir/concepts/data_types/arrays.md

noir_stdlib/src/array/mod.nr

Co-authored-by: Ary Borenszweig <asterite@gmail.com>

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `079d5c6`	Previous: `c63cc73`	Ratio
`rollup-merge`	`1.174` s	`0.916` s	`1.28`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

iAmMichaelConnor · 2025-02-18T09:56:24Z

Bump for a pretty green tick, please :)

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `c3dd1be`	Previous: `582f56e`	Ratio
`AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob`	`65` s	`51` s	`1.27`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions · 2025-02-20T10:05:26Z

FYI @noir-lang/developerrelations on Noir doc changes.

TomAFrench

LGTM

feat: add optional oracle resolver url in `acvm_cli` (noir-lang/noir#7630) chore: Rename `StructDefinition` to `TypeDefinition` (noir-lang/noir#7614) fix: Error on infinitely recursive types (noir-lang/noir#7579) fix: update error message to display 128 bits as valid bit size (noir-lang/noir#7626) chore: update docs to reflect u128 type (noir-lang/noir#7623) feat: array concat method (noir-lang/noir#7199)

chore: remove unnecessary trait bounds (noir-lang/noir#7635) feat: add optional oracle resolver url in `acvm_cli` (noir-lang/noir#7630) chore: Rename `StructDefinition` to `TypeDefinition` (noir-lang/noir#7614) fix: Error on infinitely recursive types (noir-lang/noir#7579) fix: update error message to display 128 bits as valid bit size (noir-lang/noir#7626) chore: update docs to reflect u128 type (noir-lang/noir#7623) feat: array concat method (noir-lang/noir#7199)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: bump external pinned commits (noir-lang/noir#7640) chore: remove unnecessary trait bounds (noir-lang/noir#7635) feat: add optional oracle resolver url in `acvm_cli` (noir-lang/noir#7630) chore: Rename `StructDefinition` to `TypeDefinition` (noir-lang/noir#7614) fix: Error on infinitely recursive types (noir-lang/noir#7579) fix: update error message to display 128 bits as valid bit size (noir-lang/noir#7626) chore: update docs to reflect u128 type (noir-lang/noir#7623) feat: array concat method (noir-lang/noir#7199) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch>

🤖 I have created a new Aztec Packages release --- ## [0.79.0](v0.78.1...v0.79.0) (2025-03-11) ### ⚠ BREAKING CHANGES * aggregate data for batch calls ([#12562](#12562)) ### Features * add extra attributes to target_info ([#12583](#12583)) ([c296422](c296422)) * add optional oracle resolver url in `acvm_cli` (noir-lang/noir#7630) ([cc6cdbb](cc6cdbb)) * allow to pay via sponsored fpc from cli ([#12598](#12598)) ([877de5c](877de5c)) * array concat method (noir-lang/noir#7199) ([cc6cdbb](cc6cdbb)) * **avm:** ToRadix gadget ([#12528](#12528)) ([02a7171](02a7171)) * aztec-up -v flag ([#12590](#12590)) ([6a41565](6a41565)) * **bb:** consider polynomial end_index when constructing partially evaluated multivariates ([#12530](#12530)) ([abd22cd](abd22cd)) * **config:** add fallbacks ([#12593](#12593)) ([f2f9ef3](f2f9ef3)) * **p2p:** add trusted peers mechanics ([#12447](#12447)) ([d67f7e8](d67f7e8)) * **p2p:** peer manager peer count metrics ([#12575](#12575)) ([b4891c1](b4891c1)) * provision alerts ([#12561](#12561)) ([2ea1767](2ea1767)) * Resolve callstacks in protocol circuit errors on wasm ([#12573](#12573)) ([657299b](657299b)) ### Bug Fixes * aggregate data for batch calls ([#12562](#12562)) ([bd0b3b6](bd0b3b6)) * broken kind transfer test ([#12611](#12611)) ([6e91934](6e91934)) * Cl/release fixes 2 ([#12595](#12595)) ([fc597f4](fc597f4)) * Cl/release noir refs ([#12597](#12597)) ([fdcfcaf](fdcfcaf)) * demote log ([#12626](#12626)) ([bec8953](bec8953)) * deploy method test ([#12609](#12609)) ([f2c06c2](f2c06c2)) * Do not report epoch as complete until blocks have synced ([#12638](#12638)) ([2ddfa76](2ddfa76)), closes [#12625](#12625) * Error on infinitely recursive types (noir-lang/noir#7579) ([cc6cdbb](cc6cdbb)) * get L1 tx utils config from env ([#12620](#12620)) ([d930c01](d930c01)) * Log overflow handling in reset ([#12579](#12579)) ([283b624](283b624)) * metrics update ([#12571](#12571)) ([80a5df2](80a5df2)) * **sandbox:** query release please manifest for version if in a docker container ([#12591](#12591)) ([db8ebc6](db8ebc6)) * **spartan:** setup needs kubectl ([#12580](#12580)) ([753cb33](753cb33)) * update dead partial notes link ([#12629](#12629)) ([5a1dc4c](5a1dc4c)) * update error message to display 128 bits as valid bit size (noir-lang/noir#7626) ([cc6cdbb](cc6cdbb)) * update fallback transport ([#12470](#12470)) ([88f0711](88f0711)) ### Miscellaneous * bump external pinned commits (noir-lang/noir#7640) ([cc6cdbb](cc6cdbb)) * **ci3:** add helper for uncached test introspection ([#12618](#12618)) ([9ac518b](9ac518b)) * **ci3:** better memsuspend_limit comment ([#12622](#12622)) ([de84187](de84187)) * clean up upgrade test and other small things ([#12558](#12558)) ([c28abe1](c28abe1)) * cleanup eth artifacts + misc aztec.js reorg ([#12563](#12563)) ([6623244](6623244)) * **docs:** Updated accounts page ([#12019](#12019)) ([d45dac9](d45dac9)) * Fix mac build ([#12610](#12610)) ([adceed6](adceed6)) * gemini soundness regression test ([#12570](#12570)) ([c654106](c654106)) * more sane e2e_prover/full timeout ([#12619](#12619)) ([add9d35](add9d35)) * reactivate acir_test for `regression_5045` ([#12548](#12548)) ([c89f89c](c89f89c)) * remove unnecessary trait bounds (noir-lang/noir#7635) ([cc6cdbb](cc6cdbb)) * Rename `StructDefinition` to `TypeDefinition` (noir-lang/noir#7614) ([cc6cdbb](cc6cdbb)) * replace relative paths to noir-protocol-circuits ([4f7f5c3](4f7f5c3)) * replace relative paths to noir-protocol-circuits ([0f68d11](0f68d11)) * replace relative paths to noir-protocol-circuits ([8f593ce](8f593ce)) * replace relative paths to noir-protocol-circuits ([251ae38](251ae38)) * rollup library cleanup ([#12621](#12621)) ([361fc59](361fc59)) * **sandbox:** drop cheat-codes log level ([#12586](#12586)) ([24f04c7](24f04c7)) * **sandbox:** expose anvil port ([#12599](#12599)) ([955f1b0](955f1b0)) * **testnet:** updating script for ignition, change naming ([#12566](#12566)) ([2d7b69d](2d7b69d)) * turn on masking in eccvm ([#12467](#12467)) ([aacb91a](aacb91a)) * Update Bb line counting script ([#12350](#12350)) ([7a41843](7a41843)) * update docs to reflect u128 type (noir-lang/noir#7623) ([cc6cdbb](cc6cdbb)) * Validate blobs posted to sink belong to our L2 ([#12587](#12587)) ([9578f1e](9578f1e)), closes [#12497](#12497) ### Documentation * update cli-wallet commands in profiler doc ([#12568](#12568)) ([239a4fb](239a4fb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

iAmMichaelConnor added 2 commits January 27, 2025 20:07

feat: array concat method

cac6146

docs

e7ebdee

github-actions bot added the documentation Improvements or additions to documentation label Jan 27, 2025

add 'concat' to cspell

b0222ae

github-actions bot reviewed Jan 27, 2025

View reviewed changes

iAmMichaelConnor added 2 commits January 27, 2025 20:35

test: add a test

24b92f4

fmt

d161a0d

iAmMichaelConnor requested a review from jfecher January 27, 2025 21:13

iAmMichaelConnor mentioned this pull request Jan 27, 2025

feat: concat3 #7200

Closed

5 tasks

TomAFrench reviewed Jan 28, 2025

View reviewed changes

docs/docs/noir/concepts/data_types/arrays.md Show resolved Hide resolved

TomAFrench reviewed Jan 28, 2025

View reviewed changes

noir_stdlib/src/array/mod.nr Outdated Show resolved Hide resolved

Update noir_stdlib/src/array/mod.nr

73585c3

iAmMichaelConnor mentioned this pull request Jan 31, 2025

In some docs: replace manual code snippets with imported code snippets #7251

Open

asterite reviewed Feb 3, 2025

View reviewed changes

noir_stdlib/src/array/mod.nr Outdated Show resolved Hide resolved

Update noir_stdlib/src/array/mod.nr

c472a26

Co-authored-by: Ary Borenszweig <asterite@gmail.com>

github-actions bot reviewed Feb 11, 2025

View reviewed changes

iAmMichaelConnor added 3 commits February 12, 2025 15:56

Merge branch 'master' into mc/array-concat

c7e0b89

test zero-length inputs

f88051b

Merge branch 'master' into mc/array-concat

c3dd1be

github-actions bot reviewed Feb 18, 2025

View reviewed changes

Merge branch 'master' into mc/array-concat

079d5c6

TomAFrench approved these changes Mar 7, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Mar 7, 2025

Merged via the queue into master with commit 5b725bb Mar 7, 2025
102 checks passed

TomAFrench deleted the mc/array-concat branch March 7, 2025 11:19

noirwhal mentioned this pull request Mar 7, 2025

chore: Release Noir(1.0.0-beta.4) #7475

Merged

AztecBot mentioned this pull request Mar 8, 2025

feat: Sync from noir AztecProtocol/aztec-packages#12594

Closed

This was referenced Mar 10, 2025

feat: Sync from noir AztecProtocol/aztec-packages#12606

Closed

chore: Bump Noir reference AztecProtocol/aztec-packages#12607

Closed

chore: Bump Noir reference AztecProtocol/aztec-packages#12608

Closed

This was referenced Mar 11, 2025

feat: Sync from noir AztecProtocol/aztec-packages#12624

Merged

chore: Bump Noir reference AztecProtocol/aztec-packages#12628

Closed

AztecBot mentioned this pull request Mar 11, 2025

chore(master): release 0.79.0 AztecProtocol/aztec-packages#12578

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: array concat method#7199

feat: array concat method#7199
TomAFrench merged 11 commits intomasterfrom
mc/array-concat

iAmMichaelConnor commented Jan 27, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

iAmMichaelConnor commented Feb 18, 2025

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

TomAFrench left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

iAmMichaelConnor commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

iAmMichaelConnor commented Feb 18, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot commented Feb 20, 2025

Uh oh!

TomAFrench left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iAmMichaelConnor commented Jan 27, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading