Skip to content

feat(ssa): Reuse constants from the globals graph when making constants in a function DFG #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Jan 22, 2025
Merged

feat(ssa): Reuse constants from the globals graph when making constants in a function DFG #7153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion compiler/noirc_evaluator/src/ssa/ir/dfg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,14 @@ pub(crate) struct GlobalsGraph {
/// All of the instructions in the global value space.
/// These are expected to all be Instruction::MakeArray
instructions: DenseMap<Instruction>,

#[serde(skip)]
constants: HashMap<(FieldElement, NumericType), ValueId>,
}

impl GlobalsGraph {
pub(crate) fn from_dfg(dfg: DataFlowGraph) -> Self {
Self { values: dfg.values, instructions: dfg.instructions }
Self { values: dfg.values, instructions: dfg.instructions, constants: dfg.constants }
}

/// Iterate over every Value in this DFG in no particular order, including unused Values
Expand Down Expand Up @@ -386,6 +389,9 @@ impl DataFlowGraph {
if let Some(id) = self.constants.get(&(constant, typ)) {
return *id;
}
if let Some(id) = self.globals.constants.get(&(constant, typ)) {
return *id;
}
let id = self.values.insert(Value::NumericConstant { constant, typ });
self.constants.insert((constant, typ), id);
id
Expand Down
Loading