fix: Simplify defunctionalize return#7101
Merged
TomAFrench merged 3 commits intofix-defunctionalize-runtimefrom Jan 17, 2025
Merged
fix: Simplify defunctionalize return#7101TomAFrench merged 3 commits intofix-defunctionalize-runtimefrom
TomAFrench merged 3 commits intofix-defunctionalize-runtimefrom
Conversation
Contributor
Compilation Report
|
Contributor
Execution Report
|
Contributor
Compilation Memory Report
|
Contributor
Execution Memory Report
|
7ace374 to
4e3ea96
Compare
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
TomAFrench
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Extracted from #7072
Depends on #7100 to fix SSA parsing
Summary*
Skips the creation of unnecessary blocks in the
applyfunctions duringdefunctionalize, jumping straight to the return block.Additional Context
At the time I thought it might play a role in the inlining cost calculation, causing the
applyto be too expensive to inline because it affects the weight. It turned out the function was too expensive to inline even with this change.These blocks would be removed by a
simplifypass, but I didn't see a reason they should be generated in the first place.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.