feat: add more lazy removal of instructions with Instruction::noop#7035
Closed
TomAFrench wants to merge 1 commit intomasterfrom
Closed
feat: add more lazy removal of instructions with Instruction::noop#7035TomAFrench wants to merge 1 commit intomasterfrom
Instruction::noop#7035TomAFrench wants to merge 1 commit intomasterfrom
Conversation
Contributor
Execution Memory Report
|
Contributor
Compilation Memory Report
|
Contributor
Compilation Report
|
Contributor
Execution Report
|
ae72537 to
7087c8d
Compare
Contributor
|
Interesting this looks like it is either increasing compilation times or has no substantial effect |
Member
Author
|
Yeah in hindsight the benefits from avoiding rebuilding the instructions vec at the end of these passes are probably outweighed by the costs of having a bloated input to the next pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Followup to #6899
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.