Skip to content

feat: impl Default for U128 #6984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfecher merged 1 commit into from
Jan 8, 2025
Merged

feat: impl Default for U128 #6984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion noir_stdlib/src/uint128.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::cmp::{Eq, Ord, Ordering};
use crate::ops::{Add, BitAnd, BitOr, BitXor, Div, Mul, Not, Rem, Shl, Shr, Sub};
use super::convert::AsPrimitive;
use super::{convert::AsPrimitive, default::Default};

global pow64: Field = 18446744073709551616; //2^64;
global pow63: Field = 9223372036854775808; // 2^63;
Expand Down Expand Up @@ -331,7 +331,14 @@ impl Shr for U128 {
}
}

impl Default for U128 {
fn default() -> Self {
U128::zero()
}
}

mod tests {
use crate::default::Default;
use crate::ops::Not;
use crate::uint128::{pow63, pow64, U128};

Expand Down Expand Up @@ -565,4 +572,9 @@ mod tests {
),
);
}

#[test]
fn test_default() {
assert_eq(U128::default(), U128::zero());
}
}