feat: Add Hash impls for EmbeddedCurvePoint and EmbeddedCurveScalar#6970
Merged
feat: Add Hash impls for EmbeddedCurvePoint and EmbeddedCurveScalar#6970
Conversation
Contributor
Compilation Memory Report
|
Contributor
Execution Memory Report
|
asterite
approved these changes
Jan 7, 2025
Member
|
Seeing a lot of red here. |
Contributor
Author
|
@TomAFrench looks like those external repos have their own trait with a different Hash function. Now that these types implement std::hash::Hash, it is being resolved to that instead leading to the parameter count error. Those external libraries in aztec-packages will need to be updated. We may need #6895 to be merged first and to update aztec-packages to only import the trait containing the no argument hash function. |
michaeljklein
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Replaces #6918
Summary*
Thanks to @skaunov for the original issue. This needed to be broken into a separate PR since I couldn't suggest these changes on the original.
Implements Hash for two types so that they can be put in HashMaps, etc.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.