feat!: require trait primitive functions/calls to have their trait in scope#6900
Merged
asterite merged 6 commits intoab/require-trait-to-be-in-scope-for-methodsfrom Dec 20, 2024
Conversation
Contributor
Peak Memory Sample
|
Contributor
Compilation Sample
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on top of #6895
Problem
Part of #6864
Summary
Similar to the previous PRs but this time for primitive types.
Additional Context
I think what's missing now is to do the same for "generic" types, for example if there's a trait impl for every
(T), calling a method of that trait on a tuple might not currently require the trait to be in scope. But I'll do this in a follow-up PR.Documentation
Check one:
PR Checklist
cargo fmton default settings.