chore: Test new bench report only showing seconds#6881
Closed
vezenovm wants to merge 1 commit intomv/reports-in-secondsfrom
Closed
chore: Test new bench report only showing seconds#6881vezenovm wants to merge 1 commit intomv/reports-in-secondsfrom
vezenovm wants to merge 1 commit intomv/reports-in-secondsfrom
Conversation
Contributor
Peak Memory Sample
|
Contributor
Compilation Sample
|
Contributor
Execution Sample
|
5 tasks
Contributor
Author
|
These reports are displayed accurately so closing and we can merge the parent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
I opened this PR just to test against #6880. All diffs in that PR (#6880 (comment)) are reporting a diff percentage of infinity. This is due to us needing special handling for the old report that has minutes as part of its time.
Summary*
I want to see whether we can generate an accurate report with by opening up a child report alone and without having to do any special handling in https://github.com/noir-lang/noir-bench-report
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.