feat!: nargo::ops::test::run_test generic in ForeignCallExecutor#6858
Merged
aakoshh merged 2 commits into6742-jsonrpseefrom Dec 19, 2024
Merged
feat!: nargo::ops::test::run_test generic in ForeignCallExecutor#6858aakoshh merged 2 commits into6742-jsonrpseefrom
nargo::ops::test::run_test generic in ForeignCallExecutor#6858aakoshh merged 2 commits into6742-jsonrpseefrom
Conversation
5 tasks
Merged
5 tasks
Contributor
Peak Memory Sample
|
Contributor
Compilation Sample
|
TomAFrench
approved these changes
Dec 18, 2024
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
I've been wanting to separate the executor creation from the test runner more so this is great.
Base automatically changed from
6742-refactor-foreign-calls
to
6742-jsonrpsee
December 19, 2024 09:17
aakoshh
force-pushed
the
6742-run-test-generic-foreign
branch
from
65283d7 to
f8936ca
Compare
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Execution Sample
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Follow up for #6857
Fixes the Wasm compilation in #6849
Summary*
Changes
nargo::ops::test::run_testto take a generic function to create aForeignCallExecutor, rather than a URL which it used for now to create a HTTP client, which would not compile to wasm, clashing with the goals of #6835Refactored
nargoto make it possible to import thetestfeatures without therpcstuff. Changed the feature flags to only disable theDefaultForeignCallExecutorfor Wasm.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.