Skip to content

chore: move constant creation out of loop #6836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Dec 17, 2024
Merged

chore: move constant creation out of loop #6836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions compiler/noirc_evaluator/src/ssa/opt/resolve_is_unconstrained.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,15 @@ impl Function {
}
}

let is_unconstrained = matches!(self.runtime(), RuntimeType::Brillig(_)).into();
let is_within_unconstrained = self.dfg.make_constant(is_unconstrained, NumericType::bool());
for instruction_id in is_unconstrained_calls {
let call_returns = self.dfg.instruction_results(instruction_id);
let original_return_id = call_returns[0];

// We replace the result with a fresh id. This will be unused, so the DIE pass will remove the leftover intrinsic call.
self.dfg.replace_result(instruction_id, original_return_id);

let is_unconstrained = matches!(self.runtime(), RuntimeType::Brillig(_)).into();
let is_within_unconstrained =
self.dfg.make_constant(is_unconstrained, NumericType::bool());
// Replace all uses of the original return value with the constant
self.dfg.set_value_from_id(original_return_id, is_within_unconstrained);
}
Expand Down