chore: Update memory report to run noir-contracts repo#6809
Closed
chore: Update memory report to run noir-contracts repo#6809
Conversation
Contributor
Compilation Sample
|
Contributor
Peak Memory Sample
|
Contributor
Author
|
Ok looks like the |
Contributor
Execution Sample
|
Contributor
Author
|
It still takes about 28 minutes to generate the report @TomAFrench. Not sure if we want to merge this to run like every other report. If we do, then this report will become the bottleneck for CI. |
Member
|
Yeah I agree 28 minutes is too much. |
Member
|
We may want to pull out a couple of contracts in particular that are interesting but running a whole workspace is a waste of time. |
Member
|
Closing this PR as I've updated the issue with the extra context on CI times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6883
Summary*
I just saw #6807 and noticed that
ram_blowup_regressionwent down by 50%. I remembered that this is a pattern common in the noir contracts so I want to test bringing back the noir-contracts repo to the memory report. Previously it took just under 30 minutes and had a peak memory of ~9 GB.After #6875 the report now finishes in the CI report. It finishes in ~28 minutes.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.