chore: Test RcTracker with starting inc_rc elision re-added#6797
Closed
jfecher wants to merge 2 commits intomv/bring-back-rc-trackerfrom
Closed
chore: Test RcTracker with starting inc_rc elision re-added#6797jfecher wants to merge 2 commits intomv/bring-back-rc-trackerfrom
jfecher wants to merge 2 commits intomv/bring-back-rc-trackerfrom
Conversation
5 tasks
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Peak Memory Sample
|
Contributor
Compilation Sample
|
Contributor
Looks like the first assert in |
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Member
|
Seems like we're getting correctness issues inside of bigcurve again. |
Contributor
Author
|
Those are expected since this should have no changes compared to the breaking version that was removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Fork of #6783 to test it on external repos with the change to start reference counts at 2 reverted to start at 1 again.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.