chore(ci): run noir-lang/big_curve tests on single thread#6789
Closed
TomAFrench wants to merge 4 commits intomasterfrom
Closed
chore(ci): run noir-lang/big_curve tests on single thread#6789TomAFrench wants to merge 4 commits intomasterfrom
noir-lang/big_curve tests on single thread#6789TomAFrench wants to merge 4 commits intomasterfrom
Conversation
TomAFrench
commented
Dec 12, 2024
Contributor
Peak Memory Sample
|
Contributor
Compilation Sample
|
Member
Author
|
Blocked by noir-lang/noir_bigcurve#22 |
Member
Author
|
Not necessary anymore as we can run tests on default settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR sets the
RAYON_NUM_THREADSenvironment variable to 1 when running the bigcurve tests inrun-external-checks. This should allow us to run all of the bigcurve tests in our CI to help avoid regressions such as those caused by #6685.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.