-
Notifications
You must be signed in to change notification settings - Fork 377
fix: allow empty loop headers #6736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8deea1b
allow empty loop headers
guipublic 2807036
Merge branch 'master' into gd/issue_6734
guipublic 2b56f10
add regression test
guipublic f3f65d5
Update test_programs/execution_success/regression/src/main.nr
2aaebfe
Merge branch 'master' into gd/issue_6734
guipublic de23e6f
format
guipublic 28ad3f2
.
TomAFrench 177a658
.
TomAFrench File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| [package] | ||
| name = "regression_6734" | ||
| type = "bin" | ||
| authors = [""] | ||
|
|
||
| [dependencies] |
24 changes: 24 additions & 0 deletions
24
test_programs/execution_success/regression_6734/src/main.nr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // https://github.com/noir-lang/noir/issues/6734 | ||
|
|
||
| pub fn sub_array_extended<let SRC_LEN: u32, let DST_LEN: u32>( | ||
| src: [Field; SRC_LEN], | ||
| offset: u32, | ||
| ) -> [Field; DST_LEN] { | ||
| let available_elements_to_copy = SRC_LEN - offset; | ||
| let elements_to_copy = if DST_LEN > available_elements_to_copy { | ||
| available_elements_to_copy | ||
| } else { | ||
| DST_LEN | ||
| }; | ||
|
|
||
| let mut dst: [Field; DST_LEN] = std::mem::zeroed(); | ||
| for i in 0..elements_to_copy { | ||
| dst[i] = src[i + offset]; | ||
| } | ||
|
|
||
| dst | ||
| } | ||
|
|
||
| unconstrained fn main() { | ||
| assert_eq(sub_array_extended([], 0), []); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.