-
Notifications
You must be signed in to change notification settings - Fork 386
chore: add script to check for critical libraries supporting a given Noir version #6697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
91c5432
chore: add script to check for critical library
TomAFrench bf71614
.
TomAFrench c838cd6
Update test-js-packages.yml
TomAFrench 122fa5e
Update CRITICAL_NOIR_LIBRARIES
TomAFrench a0c4a5d
Update .github/workflows/test-js-packages.yml
TomAFrench f2b9dde
Merge branch 'master' into tf/check-critical-libs
TomAFrench f769653
.
TomAFrench a71af37
Update scripts/check-critical-libraries.sh
TomAFrench 3bf778d
.
TomAFrench 7c4fe1e
.
TomAFrench b21c09c
.
TomAFrench b02232b
.
TomAFrench 644e0d4
.
TomAFrench d90261a
.
TomAFrench File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| https://github.com/noir-lang/ec | ||
| https://github.com/noir-lang/eddsa | ||
| https://github.com/noir-lang/mimc | ||
| https://github.com/noir-lang/schnorr | ||
| https://github.com/noir-lang/noir_sort | ||
| https://github.com/noir-lang/noir-edwards | ||
| https://github.com/noir-lang/noir-bignum | ||
| https://github.com/noir-lang/noir_bigcurve | ||
| https://github.com/noir-lang/noir_base64 | ||
| https://github.com/noir-lang/noir_string_search | ||
| https://github.com/noir-lang/sparse_array | ||
| https://github.com/noir-lang/noir_rsa | ||
| https://github.com/noir-lang/noir_json_parser | ||
TomAFrench marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| #!/usr/bin/env bash | ||
| set -e | ||
|
|
||
| # Run relative to repo root | ||
| cd $(dirname "$0")/../ | ||
|
|
||
| if [[ -z $1 ]]; then | ||
| echo "Must specify Noir release to test against" >&2 | ||
TomAFrench marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| echo "usage: ./check-critical-libraries.sh <release-version>" >&2 | ||
| exit 1 | ||
| fi | ||
| noirup -v $1 | ||
|
|
||
| CRITICAL_LIBRARIES=$(grep -v "^#\|^$" ./CRITICAL_NOIR_LIBRARIES) | ||
| readarray -t REPOS_TO_CHECK < <(echo "$CRITICAL_LIBRARIES") | ||
|
|
||
| getLatestReleaseTagForRepo() { | ||
| REPO_NAME=$1 | ||
| TAG=$(gh release list -R $REPO_NAME --json 'tagName,isLatest' -q '.[] | select(.isLatest == true).tagName') | ||
| if [[ -z $TAG ]]; then | ||
| echo "$REPO_NAME has no valid release" >&2 | ||
| exit 1 | ||
| fi | ||
| echo $TAG | ||
| } | ||
|
|
||
| for REPO in ${REPOS_TO_CHECK[@]}; do | ||
| echo $REPO | ||
| TMP_DIR=$(mktemp -d) | ||
|
|
||
| TAG=$(getLatestReleaseTagForRepo $REPO) | ||
| git clone $REPO -c advice.detachedHead=false --depth 1 --branch $TAG $TMP_DIR | ||
|
|
||
| nargo test --program-dir $TMP_DIR | ||
|
|
||
| rm -rf $TMP_DIR | ||
| done | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.