Skip to content

chore: ignore almost-empty directories in nargo_cli tests #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Nov 25, 2024
Merged

chore: ignore almost-empty directories in nargo_cli tests #6611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tooling/nargo_cli/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,22 @@ fn read_test_cases(
let test_case_dirs =
fs::read_dir(test_data_dir).unwrap().flatten().filter(|c| c.path().is_dir());

test_case_dirs.into_iter().map(|dir| {
test_case_dirs.into_iter().filter_map(|dir| {
// When switching git branches we might end up with non-empty directories that have a `target`
// directory inside them but no `Nargo.toml`.
// These "tests" would always fail, but it's okay to ignore them so we do that here.
if !dir.path().join("Nargo.toml").exists() {
return None;
}

let test_name =
dir.file_name().into_string().expect("Directory can't be converted to string");
if test_name.contains('-') {
panic!(
"Invalid test directory: {test_name}. Cannot include `-`, please convert to `_`"
);
}
(test_name, dir.path())
Some((test_name, dir.path()))
})
}

Expand Down