Add result return type to evaluate_instruction#649
Merged
kevaundray merged 2 commits intomasterfrom Jan 17, 2023
Merged
Conversation
5 tasks
guipublic
approved these changes
Jan 17, 2023
jfecher
reviewed
Jan 17, 2023
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
In the future, lets keep changes like this in the PRs they are relevant to. This change does not make sense as a standalone PR since evaluate_instruction never returns any errors to begin with. Only when looking in PR #634 can you see the added return Err(...) in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Returns a Result type for evaluate instruction. See #634 where we are currently panicking because we do not have a Result type. This is also added in #635 PR.
Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Additional context