Skip to content

chore: remove unnecessary endianness flips when outputting final sha256 hash #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAFrench wants to merge 1 commit into from
Closed

chore: remove unnecessary endianness flips when outputting final sha256 hash #6368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions noir_stdlib/src/hash/sha256.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,9 +508,9 @@ fn hash_final_block(msg_block: MSG_BLOCK, mut state: STATE) -> HASH {

// Return final hash as byte array
for j in 0..8 {
let h_bytes: [u8; 4] = (state[7 - j] as Field).to_le_bytes();
let h_bytes: [u8; 4] = (state[j] as Field).to_be_bytes();
for k in 0..4 {
out_h[31 - 4 * j - k] = h_bytes[k];
out_h[4 * j + k] = h_bytes[k];
}
}

Expand All @@ -519,11 +519,9 @@ fn hash_final_block(msg_block: MSG_BLOCK, mut state: STATE) -> HASH {

mod tests {
use super::{
attach_len_to_msg_block, build_msg_block, byte_into_item, get_item_byte, lshift8, make_item,
set_item_byte_then_zeros, set_item_zeros,
attach_len_to_msg_block, build_msg_block, byte_into_item, get_item_byte, INT_BLOCK,
make_item, set_item_byte_then_zeros, set_item_zeros, sha256_var,
};
use super::{INT_BLOCK, INT_BLOCK_SIZE, MSG_BLOCK};
use super::sha256_var;

#[test]
fn smoke_test() {
Expand Down