feat!: always print Type::Constant kinds#6080
Closed
michaeljklein wants to merge 2 commits intomasterfrom
Closed
Conversation
Contributor
Changes to Brillig bytecode sizes
There are no changes in circuit sizes |
TomAFrench
approved these changes
Sep 18, 2024
jfecher
requested changes
Sep 18, 2024
Contributor
jfecher
left a comment
There was a problem hiding this comment.
We should almost never print constant kinds, this is the same formatting which broke #6077.
We need to either only print these when they differ or use a different error type entirely for this case. We should see what Rust does here.
Contributor
|
For: struct Foo<const N: usize> {
x: [u8; N],
}
fn main() {}
fn bar<const M: u32>() -> Foo<M> {
todo!()
}Rust gives: |
Contributor
Author
|
The original issue appears to be resolved by #6083 |
auto-merge was automatically disabled
September 18, 2024 21:01
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Instead of printing:
We print:
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.