Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deprecated into_serde/from_serde #605

Merged

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Dec 27, 2022

Related issue(s)

The wasm crate is showing up in yellow with warnings.

Description

Summary of changes

I've updated the from_serde and into_serde method calls according to rustwasm/wasm-bindgen#2770

use of deprecated associated function `wasm_bindgen::JsValue::into_serde`: causes dependency cycles, use `serde-wasm-bindgen` or `gloo_utils::format::JsValueSerdeExt` instead

I've chosen the gloo_utils::format::JsValueSerdeExt method as this is closest to the current implementation.

Dependency additions / changes

None

Test additions / changes

None

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@TomAFrench TomAFrench changed the title update deprecated to_serde/from_serde update deprecated into_serde/from_serde Dec 27, 2022
@kevaundray kevaundray merged commit b40e2c8 into noir-lang:master Dec 30, 2022
@TomAFrench TomAFrench deleted the update-deprecated-wasm-bindgen branch December 31, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants